Comments (11)
Thanks, would you mind to add those tags (probably in an example osm file)?
from graphhopper.
Already working on it.
from graphhopper.
Theoretically, an access vehicle=no also excludes bicycles. In practice, cylcists ignore those signs. I'd implement the practice rather than an unrealistic, legally correct interpretation.
For ferries: If they are not marked for any particular vehicle, they are currently accepted for cars. I did some research and I believe this is wrong. The unmarked ferries are usually only for pedestrians, the large ferries that carry cars are ususally marked. So I would change this to assume that unmarked ferries are foot only.
from graphhopper.
I just noted that there are 2 CarFlagEncoder Tests and no BikeFlagEncoderTest. Is there a reason?
from graphhopper.
There is a more accurate set of allowed/disallowed ways now. Currently 4 of the routing tests are broken, probably because new edges were introduced and some were removed from the graph. The other tests are running fine.
It would be helpful to get the routing tests fixed before doing any refactoring that is not supposed to change their results, but I need help for that as I can't judge whether they are ok and the graph changed or whether there actually is something wrong.
from graphhopper.
Thanks! Some days ago I noticed the bike encoder is broken. today I'll fix it and also merge you changes!
from graphhopper.
I have used the rainy weather yesterday and done a lot more of refactoring on the encoders, maybe you should wait fort that before applying fixes. I can push it this evening.
The bike encoder does not produce valid speed values, it looks for highway values like the car encoder, but provides another set of values. Except for that, everything has been fixed and there are some improvements.
But it is lacking a test. Could you add a Bike test? I can extend existing test cases but I don't know how to add a new test class.
from graphhopper.
I merged your pull request and added a bike test.
Now bike produces valid speed values. But I think we should add 'surface' parsing for bike speed instead of 'highway' which can also improve car speeds as well e.g. for bouldering or foot speed for trail vs. road
from graphhopper.
and done a lot more of refactoring on the encoders
I would really like to take a look at it now as I would improve up on this with the surface stuff!
I can extend existing test cases but I don't know how to add a new test class.
Add a class with the same name and a 'Test' end somewhere into the src/test/java directory structure. 'somewhere' -> same package of course
from graphhopper.
Ok. How can I get your changes into my fork and try to resolve the conflicts in Git?
As I refactored the flag encoders, there's likely to be conflicts.
As for speed:
- If you parse surface you should also parse tracktype
- You will need different settings for racing bikes, trekking bikes and mountain bikes.
from graphhopper.
How can I get your changes into my fork and try to resolve the conflicts in Git?
try
git checkout master
git fetch # this will give you the latest stuff into the master branch of your fork
git merge # this will merge my changes to yours into master (if you didn't do anything in master this will just fast forward and do no merge commit)
git checkout myfork # this will switch to your fork
git merge master # now merge the changes to your fork
BTW: git pull == git fetch + git merge: http://stackoverflow.com/questions/292357/whats-the-difference-between-git-pull-and-git-fetch
If the last step produces conflicts just edit with your favorite editor/IDE. E.g. in netbeans you can easily view and revert local changes and/or git commits.
You will need different settings for racing bikes, trekking bikes and mountain bikes.
I feared that someone will suggest this ;)
Probably just an extended encoder class for every type? For now I would like to concentrate on trekking bike (just selfish reasons ;)).
If you parse surface you should also parse tracktype
Thanks! It looks like there is yet another one: http://wiki.openstreetmap.org/wiki/Key:smoothness
from graphhopper.
Related Issues (20)
- Pedestrian street with vehicles allowed not routable by car profile HOT 20
- Setting a EncodedValueFactory fails if the EnumEncodedValue class is not within `com.graphhopper.routing.ev` package
- Could not create weighting for profile: 'truck' HOT 1
- CarAverageSpeedParser should use estimated max speed HOT 1
- Implementing railway route planning based on version 7.0 HOT 2
- 8.0 Set a No-Go Zone HOT 1
- Incorrect handling of turn restrictions sharing the same via-way HOT 18
- Motorcycle profile speed section is ignored HOT 10
- Problem when using speed limit estimation and turn restrictions
- incorrect leg_distance entries if two stops are identical
- foot with turn restrictions leads to NPE for CH preparation
- Refactoring: Introduce a FSM for OSM file parsing
- new capacity has to be strictly positive with custom encoder for "piste" ways HOT 4
- Custom vehicle doesn't work after update to 8.0 HOT 5
- Wrong exit number in a roundabout if a waypoint is inside HOT 3
- Add crossing encoded values for accessible pedestrian routing. HOT 2
- Failed Import - SRTM elevation - There was an issue looking up the coordinates for - Could not parse OSM file HOT 2
- Sorting the graph is currently not supported in the presence of turn costs HOT 1
- total distance seems incorrect for alternative route HOT 1
- max_slope should be able to get negative HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphhopper.