Giter Club home page Giter Club logo

Comments (7)

HarelM avatar HarelM commented on May 26, 2024 1

@easbar the idea behind this issue is not about fixing my issue, I know I can use the forum, which is a great tool, and I know you guys are watching it and answering there, so thanks!
The idea behind this issue is to bring into your attention that some forum question can be avoided given a proper upgrade instruction, taking into consideration the things you removed/broke when decided to create a new major version release with breaking changes (which I obviously understand the need to create a breaking change version from time to time).

It might be that short_fastest is the only breaking change, I don't know, and I might be braking on the wrong tree.

Regardless, thanks a lot for all the work done on this library! It is truly appreciated.

from graphhopper.

karussell avatar karussell commented on May 26, 2024

This is tricky if you already know all the details. So here it would be nice to get contributions from the community and improve the situation where necessary. In this specific case you create a custom model with an appropriate distance_influence, where "appropriate" depends on the profile. E.g. for outdoor profiles we use 5 in production.

I'm not expecting an upgrade tool

We won't need this for every release and won't be able to create tools like this, but we already did something like this in the past.

from graphhopper.

HarelM avatar HarelM commented on May 26, 2024

The problem was not with the custom model, this was upgraded without any issues.
The problem was with mtb profile and short_fastest model.
If short_fastest was removed I think a proper note in the version release would help here.
The problem with community help here, is that I don't know what's the right way to fix the problem.
I ended up removing short fastest and add an empty array for custom model files.
See here:
IsraelHikingMap/Site@7a96a8a
(Ignore the 20 to 2 change in the 4wd as it's a different issue)

from graphhopper.

easbar avatar easbar commented on May 26, 2024

We use the forum to answer questions about version upgrades etc. If you wrote down other things you already figured out yourself it might still be useful for others.

from graphhopper.

karussell avatar karussell commented on May 26, 2024

I ended up removing short fastest and add an empty array for custom model files.

You can do that and for mtb it should be fine.

What I meant is a config like this:

   - name: mtb
     vehicle: mtb
     weighting: custom
     custom_model:
        distance_influence: 5

from graphhopper.

karussell avatar karussell commented on May 26, 2024

I agree that we previously always just linked issues which was convenient for us developers but suboptimal for users. The next version will contain a migration guide under docs/migration. Please have a look into #2938 which will be the first to have such a guide (i.e. for version 9.x). It is very likely not complete (please let us know!) and probably a longer learning process on how to do this, but it is a good start to try to have all information in one place.

Regardless, thanks a lot for all the work done on this library! It is truly appreciated.

Thanks!

from graphhopper.

HarelM avatar HarelM commented on May 26, 2024

Looks good! Thanks! I'll probably need to read it thoroughly when switching to 9 and only then provide a variable feedback, but I think it's an excellent start.

from graphhopper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.