Giter Club home page Giter Club logo

Comments (13)

soupslurpr avatar soupslurpr commented on July 18, 2024

It seems to be intentional

Gets disabled before recording starts here

mActivity.settingsDialog.enableEISToggle.isEnabled = false

Gets re-enabled when recording stops here

mActivity.settingsDialog.enableEISToggle.isEnabled = true

from camera.

Silent-Hunter avatar Silent-Hunter commented on July 18, 2024

What on Earth? Why? That seems odd.

from camera.

thestinger avatar thestinger commented on July 18, 2024

@soupslurpr That code prevents changing the state of the EIS toggle after starting the video. It doesn't disable EIS.

from camera.

soupslurpr avatar soupslurpr commented on July 18, 2024

Ah, sorry for misunderstanding that. Is it a bug then that EIS doesn't seem to work when starting the recording? I noticed this too on my Pixel 7

from camera.

ASerbinski avatar ASerbinski commented on July 18, 2024

I can confirm that reports look valid. Move the EIS switch to "on" and the field of view narrows to provide the feature's required buffer, and shaking the phone around a bit, the image appears to be stabilized. As soon as recording is enabled though, the video no longer appears to be stabilized, but still has the narrowed field of view.

My first thought is that it could be connected to some kind of logic that may disable EIS if the camera has OIS capability. Of note, Pixel 6 does have OIS on the main lens, but if I remember correctly, not on the wide angle or telephoto (pro model) lenses.

from camera.

MHShetty avatar MHShetty commented on July 18, 2024

Hey everyone,

We have filed an issue on CameraX's issue tracker for the same. The status of the filed issue can be tracked from here - https://issuetracker.google.com/issues/346692558.

Thanks a lot for reporting this issue!

from camera.

MHShetty avatar MHShetty commented on July 18, 2024

Hey everyone,

Could someone please help us out with testing a fix for this issue?

from camera.

Silent-Hunter avatar Silent-Hunter commented on July 18, 2024

How would one do that?

from camera.

MHShetty avatar MHShetty commented on July 18, 2024

How would one do that?

Hey @Silent-Hunter, are you present on Element?

from camera.

soupslurpr avatar soupslurpr commented on July 18, 2024

I can test too :)

from camera.

Silent-Hunter avatar Silent-Hunter commented on July 18, 2024

Hey @Silent-Hunter, are you present on Element?

No, sorry.

from camera.

MHShetty avatar MHShetty commented on July 18, 2024

Hey @Silent-Hunter, are you present on Element?

No, sorry.

Ohh no worries @Silent-Hunter. Thanks for reaching out!

from camera.

MHShetty avatar MHShetty commented on July 18, 2024

Hey everyone,

We have tried using the official CameraX API for video stabilization on a Pixel 7 device and that doesn't seem to work with the preview as well currently unfortunately. We have reported this issue on the official CameraX Issue Tracker.

Further updates on this issue can be tracked on https://issuetracker.google.com/issues/346692558 until there's any update directly mentioned on this GitHub issue.

Special thanks to @soupslurpr for helping us out with testing with their Pixel 7!

from camera.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.