InMemoryCache: Clear() races with sync.Map implementation about dataloader HOT 2 CLOSED

After thinking a bit more about the problem, I'm not sure that the sync.Map implementation is appropriate for the in-memory cache.

The Map type is optimized for two common use cases: (1) when the entry for a given key is only ever written once but read many times, as in caches that only grow, or (2) when multiple goroutines read, write, and overwrite entries for disjoint sets of keys. In these two cases, use of a Map may significantly reduce lock contention compared to a Go map paired with a separate Mutex or RWMutex.

https://golang.org/pkg/sync/#Map

I don't think the dataloader use case fits the intended use case since it allows for deletions and clearing, whereas the standard library's implementation is optimized for caches that only grow.

What if we dropped the special InMemoryCache_go19.go implementation and instead used the plain map protected by a sync.RWMutex?

from dataloader.

I’m cool with that.

from dataloader.