Giter Club home page Giter Club logo

Comments (2)

Satont avatar Satont commented on August 19, 2024

Is this kind of expensive operation for cloudflare? I mean usually those sql things takes small ms.

But anyways we can drop this thing and instead move those queries into readme to setup section.

Are you wanna make PR?

from storages.

treasureseth avatar treasureseth commented on August 19, 2024

I think the problem is more widespread. Many other adapters follow the same pattern of private constructor and force you to fire a create table if not exists query.

Here's the psql adapter that actually fires 2 extra queries:

private constructor(opts: AdapterConstructor) {
this.tableName = opts.tableName;
this.query = opts.query;
}
static async create(opts = { tableName: 'sessions' } as Omit<AdapterConstructor, 'query'>) {
const queryString = `
CREATE TABLE IF NOT EXISTS "${opts.tableName}" (
"key" VARCHAR NOT NULL,
"value" TEXT
)`;
const query = buildQueryRunner(opts.client);
await query(queryString);
await query(`CREATE UNIQUE INDEX IF NOT EXISTS IDX_${opts.tableName} ON "${opts.tableName}" ("key")`);
return new PsqlAdapter({
...opts,
query,
});
}

from storages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.