Giter Club home page Giter Club logo

Comments (7)

GrahamDumpleton avatar GrahamDumpleton commented on August 30, 2024

I would be careful about changing Tensorflow. They pinned the version of wrapt because they had code, or relied on a package with code which had a dependency on what was technically a bug in wrapt where it propagated something with incorrect exception type. When the bug in wrapt was fixed, this caused issues with that code Tensorflow had as it wasn't dealing correctly with what was the correct exception which would be passed back if wrapt was preserving normal Python convention. Thus Tensorflow or the package it depended on was passing back an exception it should have caught and dealt with.

That said, releasing both Python 3.11 and 3.12 wheels for wrapt 1.14.1 will not be straight forward as since then GitHub actions dropped support for Python 2.7 runners. I therefore can't just create a new 1.14.2 with actions to also build for Python 3.11 and 3.12 and follow the same release process as will not be able to recreate Python 2.7 wheels for a new 1.14.2, and since 1.4.X guarantees Python 2.7 support that would be a problem.

What I can probably do is create a 1.14.x branch in GitHub off 1.14.1, drop Python 2.7 and any other versions now not supported by GitHub actions and trigger a manual GitHub actions build using exact same code as 1.14.1. This will generate the wheel files with a version for 1.14.1 still and I can upload just those wheels against the old 1.14.1 release.

from wrapt.

GrahamDumpleton avatar GrahamDumpleton commented on August 30, 2024

You might be able to track through things in #231 to see if Tensorflow package, or package it depended on, was changed such that one can use newer wrapt version.

from wrapt.

GrahamDumpleton avatar GrahamDumpleton commented on August 30, 2024

Can you try 1.14.1 again now with Python 3.11.

It will not be possible to release Python 3.12 wheels for 1.14.1 as is, as the code in that version is not compatible with Python 3.12.

from wrapt.

GrahamDumpleton avatar GrahamDumpleton commented on August 30, 2024

Actually, it is the test harnesses in wrapt 1.14.1 which cause an issue with Python 3.12. So I can't verify it will work due to the test failures without fixing various test harnesses. :-(

from wrapt.

joeyearsley avatar joeyearsley commented on August 30, 2024

Thank you, this works for me with Py3.11

I'm happy to close this issue unless you want to keep it open for Py3.12?

from wrapt.

GrahamDumpleton avatar GrahamDumpleton commented on August 30, 2024

I'll keep it open until I confirm how much effort there might be to get that old version tested on Python 3.12.

from wrapt.

GrahamDumpleton avatar GrahamDumpleton commented on August 30, 2024

Going to close this now. Will look at issue of doing retrospective changes to support Python 3.12 in version 1.14.1 only if someone asks specifically for that.

from wrapt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.