I noticed that the git submodule in ebpf/testdata , wi

Improve developer experience with ebpf testdata about pyroscope HOT 4 OPEN

simonswine commented on June 15, 2024

Improve developer experience with ebpf testdata

from pyroscope.

Comments (4)

korniltsev commented on June 15, 2024

It looks like they are not used. Let's just remove them? (both cases)

root@pyroscopeebpftestvm:~# uname -a
Linux pyroscopeebpftestvm 5.10.205-195.807.amzn2.aarch64 #1 SMP Tue Jan 16 18:29:00 UTC 2024 aarch64 GNU/Linux
root@pyroscopeebpftestvm:~# lsmod
Module                  Size  Used by
xt_conntrack           16384  1
xt_MASQUERADE          20480  1
nf_conntrack_netlink    53248  0
nfnetlink              20480  2 nf_conntrack_netlink
iptable_nat            16384  1
nf_nat                 49152  2 iptable_nat,xt_MASQUERADE
nf_conntrack          184320  4 xt_conntrack,nf_nat,nf_conntrack_netlink,xt_MASQUERADE
nf_defrag_ipv6         24576  1 nf_conntrack
nf_defrag_ipv4         16384  1 nf_conntrack
xt_addrtype            16384  2
iptable_filter         16384  1
bpfilter               16384  0
br_netfilter           28672  0
bridge                249856  1 br_netfilter
stp                    20480  1 bridge
llc                    20480  2 bridge,stp
ghash_ce               24576  0
sha2_ce                20480  0
sha256_arm64           28672  1 sha2_ce
sha1_ce                20480  0
overlay               131072  0
uio_pdrv_genirq        20480  0
uio                    28672  1 uio_pdrv_genirq
fuse                  163840  1
loop                   40960  0
drm                   659456  0
dm_mod                151552  0
bpf_preload            16384  0
ext4                  892928  1
mbcache                24576  1 ext4
jbd2                  167936  1 ext4
virtio_net             57344  0
net_failover           24576  1 virtio_net
virtio_blk             24576  1
failover               20480  1 net_failover
virtio_pci             28672  0
virtio_mmio            24576  0
virtio_ring            36864  4 virtio_mmio,virtio_pci,virtio_blk,virtio_net
virtio                 24576  4 virtio_mmio,virtio_pci,virtio_blk,virtio_net

from pyroscope.

korniltsev commented on June 15, 2024

We can also put modules into tar.gz

from pyroscope.

aleks-p commented on June 15, 2024

Either approach sounds good to me. Putting them in an archive will reduce the chance of the problem surfacing again in the future which would be nice.

from pyroscope.

korniltsev commented on June 15, 2024

Also having a 4G git submodule may be not a great experience as well

from pyroscope.

Recommend Projects