Giter Club home page Giter Club logo

Comments (3)

56quarters avatar 56quarters commented on May 30, 2024

Useful information from printf debugging: limits are somehow over/under flowing.

=== RUN   TestIngester_Push
=== RUN   TestIngester_Push/should_discard_metadata_when_max_metadata_per_user_exceeded
checking length of metadata. len = 0, metadata = map[]
creating new metadata. limit = 2147483647, len = 0
checking length of metadata. len = 1, metadata = map[test_metric_1:map[{Type:COUNTER MetricFamilyName:test_metric_1 Help:This is a test metric. Unit:}:2024-04-26 10:56:22.995277387 -0400 EDT m=+10.048988645]]
creating new metadata. limit = 2147483647, len = 1

from mimir.

56quarters avatar 56quarters commented on May 30, 2024

This appears to be triggered by no ingesters being live in the zone when limits are computed. This means the limit code returns early with a global limit of 0 which is interpreted as "unlimited" leading to a local limit of int32.MAX.

=== RUN   TestIngester_Push/should_discard_metadata_when_max_metadata_per_user_exceeded
no ingesters in zone. ingesters in zone = 0, zone count = 1, shard size = 0
global limit = 1, local limit = 0
no ingesters in zone. ingesters in zone = 0, zone count = 1, shard size = 0
global limit = 1, local limit = 0
creating new metadata. limit = 2147483647, len = 0
global limit = 0, local limit = 0
no ingesters in zone. ingesters in zone = 0, zone count = 1, shard size = 0
global limit = 1, local limit = 0
no ingesters in zone. ingesters in zone = 0, zone count = 1, shard size = 0
global limit = 1, local limit = 0
creating new metadata. limit = 2147483647, len = 1
global limit = 0, local limit = 0

from mimir.

56quarters avatar 56quarters commented on May 30, 2024

This appears to be because we were using i.lifecycler.HealthyInstancesCount() to wait for ingester startup which doesn't actually guarantee the ingester owns any tokens. This is fixed by using a different method on i.lifecycler to wait for startup.

Ultimately this seems like the same race condition @pr00se has identified because ingesters use ring.Lifecycler from dskit instead of ring.BasicLifecycler (which waits for token ownership before completing startup).

from mimir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.