[Bug] Unable to set custom secrets without defining grafana container image about grafana-operator HOT 6 OPEN

@jamalaitahmed I think you get this problem simply because you're not redefining settings for grafana container, but, instead, you're adding a test container, where, obviously, an image must be provided, because configuration for extra containers is passed to k8s without changes from the operator side.

apiVersion: grafana.integreatly.org/v1beta1
kind: Grafana
metadata:
  labels:
    dashboards: grafana
  name: test
  namespace: test
spec:
  config:
    auth:
      disable_login_form: 'false'
    log:
      mode: console
  deployment:
    spec:
      template:
        spec:
          containers:
            - env:
                - name: GF_SECURITY_ADMIN_USER
                  valueFrom:
                    secretKeyRef:
                      key: GF_SECURITY_ADMIN_USER
                      name: test
                - name: GF_SECURITY_ADMIN_PASSWORD
                  valueFrom:
                    secretKeyRef:
                      key: GF_SECURITY_ADMIN_PASSWORD
                      name: test
              name: grafana # FIX IS HERE

P.S. You can see grafana container name in the example that @NissesSenap shared, so it's already documented.

from grafana-operator.

This is not a bug with GitOps, it's very possible to create a secret using sealed-secrets.
I use custom secrets for my grafana admin user, in my own setup and I have done it ever since version 5 was released.
The issue is that you can't set GF_SECURITY_ADMIN_USER etc. without also setting the container image.

How to do that is documented here: https://grafana.github.io/grafana-operator/docs/examples/grafana_deployment/readme/

I would argue, this isn't a huge issue, since I recommend that everyone always set a custom version of the grafana image. The main reason behind this is that grafana-operator will never be in sync with upstream grafana and minor and patches are constantly getting released by grafana.

But this is definitely a bug, and it should be able to set env variables without also setting the grafana container image.
It's a problem in our merge logic for overwriting settings.
If anyone wants to help out with this, we would love a PR.

from grafana-operator.