Giter Club home page Giter Club logo

Comments (5)

bigdaz avatar bigdaz commented on August 27, 2024

Thanks for the report. I'm quite amazed that [email protected] is working correctly with Gradle v1.12! I limit my testing to Gradle 3.x and higher.

Due to the magic of dynamic Groovy, I think simply changing:

void applyPluginExternally(PluginManager pluginManager, String pluginClassName)

to

void applyPluginExternally(def pluginManager, String pluginClassName)

might be enough to avoid failure on Gradle 1.12. The init script should then load correctly, and the code won't be executed unless you are explicitly enabling Gradle Enterprise injection (which I presume you're not).

from gradle-build-action.

bigdaz avatar bigdaz commented on August 27, 2024

@remkop I've pushed a simple attempt at a fix and it would be great if you could verify that it works.
You can test it out by running with gradle/gradle-build-action@prerelease/v2.11.1. TIA.

from gradle-build-action.

remkop avatar remkop commented on August 27, 2024

@bigdaz That works, thank you!

from gradle-build-action.

bigdaz avatar bigdaz commented on August 27, 2024

The fix has been released in v2.11.1. Thanks for the report.

from gradle-build-action.

remkop avatar remkop commented on August 27, 2024

Amazingly fast turnaround! Many thanks!

from gradle-build-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.