Giter Club home page Giter Club logo

Comments (3)

potamides avatar potamides commented on August 25, 2024

To clarify more, I think the behavior I would expect would be to call the .close() method of the generator in question immediately after it is cancelled.

from gradio.

freddyaboulton avatar freddyaboulton commented on August 25, 2024

Thanks for filing @potamides ! Would you like to open a PR?

from gradio.

potamides avatar potamides commented on August 25, 2024

Sure, if someone can give me some pointers where to look at I would be happy to do that. For starters, I tried adding something like app.iterators[event_id].iterator.close() to the following locations, but this didn't seem to work:

gradio/gradio/queueing.py

Lines 653 to 655 in d429690

async with app.lock:
del app.iterators[event_id]
app.iterators_to_reset.add(event_id)

gradio/gradio/routes.py

Lines 826 to 828 in d429690

async with app.lock:
del app.iterators[body.event_id]
app.iterators_to_reset.add(body.event_id)

from gradio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.