[WHLSL] Call arguments should be copied as soon as they are evaluated about wsl HOT 6 CLOSED

At 2018-09-06T18:00:18Z, [email protected] wrote:
Created attachment 349045
Patch

from wsl.

At 2018-09-06T18:12:27Z, [email protected] wrote:
Comment on attachment 349045
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349045&action=review

Tools/WebGPUShadingLanguageRI/Evaluator.js:325

•    let result = EBuffer.allowAllocation(() => node.func.implementation(callArguments, node));
  

I'm confused. Where do the thunks get evaluated? I expected this patch to move code around, but instead it appears to be deleting code?

from wsl.

At 2018-09-06T20:11:01Z, [email protected] wrote:
Comment on attachment 349045
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349045&action=review

Tools/WebGPUShadingLanguageRI/Evaluator.js:325

•    let result = EBuffer.allowAllocation(() => node.func.implementation(callArguments, node));
  

I'm confused. Where do the thunks get evaluated? I expected this patch to move code around, but instead it appears to be deleting code?

Got it. Looks good.

from wsl.

At 2018-09-06T20:36:49Z, [email protected] wrote:
Comment on attachment 349045
Patch

Clearing flags on attachment: 349045

Committed r235753: https://trac.webkit.org/changeset/235753

from wsl.

At 2018-09-06T20:36:50Z, [email protected] wrote:
All reviewed patches have been landed. Closing bug.

from wsl.

At 2018-09-06T20:40:26Z, [email protected] wrote:
rdar://problem/44194725

from wsl.