Fail if one of the services failed about bugwarrior HOT 4 CLOSED

Are you using the latest release (1.8.0) or the develop branch?

Related and/or duplicate issues: #897 and #866.

from bugwarrior.

I'm on 15ac6a2

from bugwarrior.

Triage:

• It seemed like we finally got the logic right in #825 and even added a regression test which should show that this specific issue is fixed. However, this issue, along with #866, draws that premise into question.
• I'm inclined to call this a duplicate of #866 since that issue includes logs which make resolution more plausible.

from bugwarrior.

I reviewed #866 and the sync logic again and still don't see how this behavior is possible. The message f"Aborted [{target}] due to critical error." is logged in collect.py, indicating bugwarrior is aware that the service failed. In db.py, the tasks to close are a subset of the tasks that did not fail.

To be clear, aborting the pull when one service fails is not ideal behavior and I don't want to revert to that unless there is compelling evidence that it is necessary. If you or anyone else has logs or insights into how this is possible I'd be happy to reconsider.

from bugwarrior.