race issues with global logging vars about gosnmp HOT 9 CLOSED

I was thinking this when code was first positioned. One could argue that the "risk" is quite low here as it's "just logging", but I agree the correct solution would be to fix.

Gut feel: I think option 2 would be best. That solution offers the benefit of also provide the option to turn on logging on a single connection.

from gosnmp.

Thanks Sam. @codedance I also think option 2 is better. Doing slog as a global var was a braino on my part; LoggingDisabled also shouldn't be global.

I'll focus on the String SET's before working on this, or someone else can work on it in the meantime. It'll be a large (but not complex) change.

from gosnmp.

Agree. So how should we dish up the work? @sam3000 , are you keen to have a shot?

from gosnmp.

I'm happy to have a look at what's involved and get back to you both.

from gosnmp.

I'm still planning to look at this at some point but it's been low on the priority list.

from gosnmp.

No worries Sam I know the feeling. After a week on the keyboard at work, it's often hard to get out the keyboard on the weekend...

from gosnmp.

Hi

Any updates on this one? Will this have any real impact on the code (i.e. can cause it to panic/crash?). Please let me know.

from gosnmp.

I sent this pull request: #59

Can someone please review?

from gosnmp.

merged and tidied.

from gosnmp.