Giter Club home page Giter Club logo

Comments (7)

caarlos0 avatar caarlos0 commented on May 22, 2024

I'm not sure I understand why this is needed... can you elaborate a little bit more?

from goreleaser.

jspc avatar jspc commented on May 22, 2024

It all depends on use case, but for where people have control over a CI box (I'm thinking of on my jenkins slaves) or where they only expect to run locally there are a couple of reasons where this would be useful:

GITHUB_TOKEN will largely not change, so using an env var isn't as useful as it could be. It would help people who tend to build for specific environments/ usecases that aren't just OSX and Linux not have to copy/paste build sections from project to project.

It would also help with stuff like #44 where people always, or even mostly, expect to override the default with a pattern.

from goreleaser.

caarlos0 avatar caarlos0 commented on May 22, 2024

@jspc hmm, I think I understood now.

Yeah, makes sense indeed.

from goreleaser.

jspc avatar jspc commented on May 22, 2024

I'll open an RFC PR later, it's largely working but I'll wait for your templating so I don't get into merge hell

from goreleaser.

caarlos0 avatar caarlos0 commented on May 22, 2024

@jspc sounds good, I plan to finish my PR tonight or tomorrow morning (gmt-3)

from goreleaser.

caarlos0 avatar caarlos0 commented on May 22, 2024

can I close this one?

from goreleaser.

github-actions avatar github-actions commented on May 22, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from goreleaser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.