Are modules broken on 2.9.0, 2.8.0? skaffold.yaml deploys, but fails to deploy when require:d as a module about skaffold HOT 6 OPEN

Hey @hgaron-blockbar! Yep, the example you added is exactly the way to configure the kubectl deployer for your use case. Behind the scene, Skaffold will first, render the manifests defined in manifests.rawYaml, and then will send them to the deploy.kubectl deployer. Hope that solves your use case. Thanks!

from skaffold.

I am having this same issue on 2.9.0; helm deployments still work in modules but rawYaml does not. If I move rawYaml to the root skaffold.yaml it will deploy correctly, but if it's inside a module, no such luck.

I have also verified skaffold correctly renders the yaml by running skaffold render > rendered.yaml and verifying the output. But any raw yaml just isn't deployed.

EDIT:
After a good deal of debugging, it looks like the rawYaml only works on the root skaffold.yaml if the requires key is omitted entirely. Even having a requires key with profiles that are not invoked breaks the rawYaml property, regardless of whether it is defined in a module or at the root skaffold.yaml.

For reference, I am also using apiVersion: skaffold/v4beta8.

from skaffold.

I downgraded to skaffold v2.8.0 and the issue persists there as well.

from skaffold.

Hello there! This is an intended behaviour: when using Skaffold modules, Skaffold itself is not able to add a default deployer. To make it work you'll need to add a deployer explicitly in the modules (deploy.*). For more context please refer to #9215 and #9138 . Thanks! 😄

from skaffold.

@renzodavid9 Forgive me but I think I misunderstand. I do have a Helm deployer present in my modules deploy.* and that works fine, but for the raw yaml manifests I'm not sure how to add a deployer?

In the v4beta8 schema, if I add a kubectl deployer there's no explicit way to define manifests (only a remoteManifests key exists). Should I just define it with an empty object?

ie.

manifests:
  rawYaml:
    - ../../manifests/*
deploy:
  kubectl: {}

Thanks for your help; cheers!

from skaffold.