Step-6: cannot send photo about webrtc-web HOT 8 OPEN

chrome is error .. but firefox is ok. You try firefox.

from webrtc-web.

Even Firefox has same issue.

from webrtc-web.

I was able to reproduce the error and identify where the issue is, but not yet the root cause.

What seems to be happening here is that dataChannel.send(len); is throwing an error because dataChannel is undefined.

This seems to be happening when the channel between the two client has not been established.
This potentially means that line 280 was not executed or ondatachannel was never completed

This can be confirmed because the console does not seem to be showing "CHANNEL opened!!!" as opposed to this scenario where all works normally:

Further research needed.

from webrtc-web.

The only way I seem to be able to reproduce this consistently is by:

1. Opening one tab. It creates the room and dataChannel.
2. Opening a second tab. It joins and connects to the dataChannel.
3. Refresh original tab.

This seems to be detecting itself as not the initiator, and it tries to make a connection. My understanding is that the other peer never created the channel to which to connect and then, this dataChannel connection is not effective.

Doing this I get almost the same console results than the exposed here.

@shamidrasool Could this be how you identified the issue?

As for what might be happening, still more research needed, but I would say that this code:

  peerConn.ondatachannel = function(event) {
    console.log('ondatachannel:', event.channel);
    dataChannel = event.channel;
    onDataChannelCreated(dataChannel);
  };

is not triggered under this circumstance.
dataChannel is defined there as event.channel which would allow to do the dataChannel.send()

The log "'ondatachannel:', event.channel" is not shown on this case, which could confirm it.

from webrtc-web.

Is there a solution for this behavior?

from webrtc-web.

@transonly Hello Ingrid, sorry for the inconvenience. At the moment, we have still not deep dive here; but I was able to reproduce the issue. I will try to come up with a fix before end of next week.

from webrtc-web.

Quick update here:

Currently working on this on nitobuendia:patch-2.

I have been able to detect most cases where connection was closed. However, connection may have been re-opened and that's not fully smooth.

To solve that issue I am trying to detect when a peer leaves and refresh the connection for all remaining peers. It might not be the smoothest way to do it, but it could work. If I get that fully working, we could consider taking a step extra and simply trying a room re-create / re-join without refresh.

Working on it.

from webrtc-web.

Quick update here. I am handling mainly two situations:

• Peer never connected >> on this situation a warning is fired explaining a picture cannot be sent until connection is made. We could as well enable / disable buttons, but this seems a fair fix for this issue for now. Further contributions can make it better.

• Peer disconnected >> on this situation, we need to manage the re-connection. In general, my first line of work is simply re-create the room. However, I want to manage immediate re-connections to avoid doing this and to avoid an infinite loop of peer join-leave reconnections. That's where I am at right now. I will keep working on it.

from webrtc-web.