Giter Club home page Giter Club logo

Comments (5)

x1ddos avatar x1ddos commented on August 18, 2024

Yeah, apparently it's a known issue: golang/go#3398
What shall we do?

@maxhawkins

from go-endpoints.

maxhawkins avatar maxhawkins commented on August 18, 2024

Yikes. That's no good.

I suppose we could put the public interface in files without a +build tag and delegate to appengine-specific implementations behind the tag. Do any of the public functions take appengine.* types as parameters?

In the meantime I suppose it makes sense to revert my PR.

from go-endpoints.

campoy avatar campoy commented on August 18, 2024

Unfortunately at least one exported function returns a user.User which means we are bound to appengine and I'm not sure we can analyze appengine depending packages from godoc.

I agree we should revert the PR adding the build tags

from go-endpoints.

dhermes avatar dhermes commented on August 18, 2024

For some side context from someone who's dealt with Endpoints and the user.User object a lot: You should not feel bad about axing it from the library.

For the long history of annoyance see the issue and for a description of the quirks, see a StackOverflow answer from me.

Take this as an opportunity to

  1. Make the docs build happily and easily with the build tags you want
  2. Drop the unnecessary "problems" discussed in #52 and #53
  3. Inform users to stop using the App Engine User ID and start using the Google User ID. (I'd imagine most codebases already have custom user classes, so this inconvenient "convenience" of returning a user.User is all around not worth it.)

😬

from go-endpoints.

x1ddos avatar x1ddos commented on August 18, 2024

This is a bug in godoc.org, which @adg will fix.

from go-endpoints.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.