Comments (7)
@st3fan we had this discussed with @dhermes back in the days of its initial implemetation in
#15 (comment)
I know it's easy to add but may confuse users. There's also an open issue on the official bug tracker of App Engine: https://code.google.com/p/googleappengine/issues/detail?id=8848
Instead, maybe we could add a new method, something like endpoints.CurrentGoogleUser
, leave CurrentUser
as is and document the difference between the two.
@campoy any thoughts on this?
from go-endpoints.
@crhym3 Yeah you are probably right. What do you think of doing something a bit more low level and instead have something like endpoints.Claims()
? That would return something like:
// Claims represents an IdToken response.
// https://developers.google.com/accounts/docs/OpenIDConnect#obtainuserinfo
type Claims struct {
Subject string `json:"sub"`
Issuer string `json:"iss"`
Email string `json:"email"`
EmailVerified bool `json:"email_verified"`
Audience string `json:"aud"`
IssuedAt uint `json:"iat"`
ExpirationTime uint `json:"exp"`
AccessTokenHash string `json:"at_hash"`
AuthorizedPresenter string `json:"azp"`
}
Then endpoints.CurrentGoogleUser
can sit on top of that.
from go-endpoints.
👍 Maybe we can then also eliminate signedJWT and just use Claims
.
Woud you modify #53 with Claims
and CurrentGooglUser
? That would be awesome.
from go-endpoints.
@crhym3 Sure, I can try to find a little time between Christmas and New Year to hack on that.
from go-endpoints.
Hey @st3fan, do you have any news on this?
I'll be using this package for a course soon and I would like to make sure after this the API is as stable as possible 😄
from go-endpoints.
Hi @campoy .. maybe someone else can pick this up? I have abandoned the project that I was initially using this code for so it is difficult for me to work on this right now. Maybe @crhym3 has a better idea about what to do here?
from go-endpoints.
Yeah, I'll take it.
from go-endpoints.
Related Issues (20)
- 2 errors on Windows 7 with "goapp serve helloworld/" HOT 13
- Remove debugging HOT 1
- Parameters from URL path are not decoded. HOT 1
- Service should recover from panic and display an internal server error
- Error while go-getting: use of internal package not allowed HOT 5
- certExpirationTime always returns 0 HOT 12
- Unexpected configuration Error HOT 3
- GAE Cloud Endpoints API Explorer stopped working HOT 1
- Remove appengine/internal depedencies HOT 2
- Path parameters inconsistently handle JSON name overrides, "req[uired]" tag.
- Angular 2 + Go endpoints HOT 1
- Is this idiomatic? HOT 1
- Structures using custom types fail to set default values during validation. HOT 1
- Nested slices are not supported.
- Is it possible to get profile information in an id_token from Google? HOT 1
- Post requests for discovery document?
- Support x-www-form-urlencoded data in POST methods
- This project has open issues from a year ago, is this project reliable for production use? HOT 6
- Can not upload project
- Cloud Endpoints v1 is deprecated - any thoughts about migrating to v2? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-endpoints.