Provide progress indicator. about link-to-text-fragment HOT 6 CLOSED

For some reason the native feature "thinks" the text is unlinkable:

However, a manually created link works just fine: https://service.unece.org/trade/locode/gb.htm#:~:text=NRW.

The extension blocks the page and the tab becomes unresponsive.

I have filed https://crbug.com/1465883. The native Chrome implementation and the extension use essentially the same algorithm for creating links. Looks like there's an issue.

from link-to-text-fragment.

If you ever need to wait for a link to be created, something is wrong with the algorithm, which is outside of this repo (see the link to the algorithm repo above). Also, there's no way to know how long you'd have to wait, so at best, we could show a meaningless spinner.

from link-to-text-fragment.

Missing context: the extension uses the algorithm implemented in https://github.com/GoogleChromeLabs/text-fragments-polyfill.

from link-to-text-fragment.

@tomayac, why close the issue? I still think that a progress indicator would be really useful, as would asynchronous operations (although perhaps better in a separate issue?)

from link-to-text-fragment.

Yeah, @tomayac, even a spinner would have made diagnosing the issue easier.

from link-to-text-fragment.

This was really an exceptional case, where for some reason the entire page got blocked. The Chrome bug is the place to star if you want to follow up. Thank you.

from link-to-text-fragment.