Giter Club home page Giter Club logo

Comments (17)

addyosmani avatar addyosmani commented on May 31, 2024 1

Nice! Good start :) Some quick notes:

  • We might want to use SVG versions of the Material icons as we'll probably only need to pull in a few vs all of Material Icons font https://material.io/resources/icons/?style=baseline
  • Image for the right-hand-side can be found here: low-data-small.png.zip
  • Content-wise, it might make sense for us to include snippets from the Hooks readme so folks can easily see how to use them in the same place?

from adaptive-loading.

addyosmani avatar addyosmani commented on May 31, 2024 1

Fonts: I think we can safely opt for Roboto as long as we are using a safe font-display default to minimize invisible text being shown.

Could you please send me a fav icon and the main icon highlighted in red?

yes, i'll dig that up right now.

from adaptive-loading.

anton-karlovskiy avatar anton-karlovskiy commented on May 31, 2024

@addyosmani
I think I have understood the outline of this microsite.

As for the theming, shall we use material-ui?

from adaptive-loading.

addyosmani avatar addyosmani commented on May 31, 2024

I think as long as we can keep the performance of our landing page high, using Material UI sounds fine. The alternative might be looking at one of the smaller sized Material implementations.

In my view, we mostly need a Material navigation bar (could be CSS if not opting for a drawer). The rest is pretty custom. I don't think we necessarily need to use cards or FAB buttons for this page. Picturing the links just being links :)

from adaptive-loading.

anton-karlovskiy avatar anton-karlovskiy commented on May 31, 2024

@addyosmani
Yes, I got your points.
Using Material UI might be expensive regarding the performance.
I think we can just use Material components as many as required without installing the whole Material UI framework. Actually just with CSS, we could implement the feel and look.

from adaptive-loading.

addyosmani avatar addyosmani commented on May 31, 2024

👍👍👍

from adaptive-loading.

addyosmani avatar addyosmani commented on May 31, 2024

SVG artwork for the main image can be found attached 📦

art-svgomg.svg.zip

from adaptive-loading.

anton-karlovskiy avatar anton-karlovskiy commented on May 31, 2024

@addyosmani

Currently it's bootstrapped with create-next-app and necessary configuration is done including AppBar and Drawer. I was going to ask assets. :)

from adaptive-loading.

anton-karlovskiy avatar anton-karlovskiy commented on May 31, 2024

@addyosmani

Thank you for your feedback. It's just the beginning of the project for now.
Yes, I remember the svg icon usage to improve the performance, which you taught me the other day.

from adaptive-loading.

addyosmani avatar addyosmani commented on May 31, 2024

Hey Anton. For the purposes of priorities next week, could we focus on #86 and #83 then come back to the microsite?

from adaptive-loading.

anton-karlovskiy avatar anton-karlovskiy commented on May 31, 2024

Hey Anton. For the purposes of priorities next week, could we focus on #86 and #83 then come back to the microsite?

Yes, I'll proceed that way.

from adaptive-loading.

anton-karlovskiy avatar anton-karlovskiy commented on May 31, 2024

@addyosmani

Could you please send me a fav icon and the main icon highlighted in red?
67242601-b2e96000-f40a-11e9-8978-d4a8054c6569
Thanks.

from adaptive-loading.

anton-karlovskiy avatar anton-karlovskiy commented on May 31, 2024

@addyosmani

In the material design, Roboto font is used. What kind of font shall we use?

from adaptive-loading.

addyosmani avatar addyosmani commented on May 31, 2024

An SVG version of the icon can be found below:

iconfinder_comparison_data_analytics_4272271.svg.zip

Favicons for the page, generated with realfavicongenerator can also be found below:

favicon_package_v0.16 (1).zip

from adaptive-loading.

anton-karlovskiy avatar anton-karlovskiy commented on May 31, 2024

@addyosmani

Roboto font is set across the website with font-display swap.

from adaptive-loading.

anton-karlovskiy avatar anton-karlovskiy commented on May 31, 2024

@addyosmani

Next.js has some problem with css module importing.
They are working on it but not resolved yet.
So I just adopted the workaround for importing some css module.

Re:
vercel/next-plugins#282
vercel/next.js#5598 (comment)
vercel/next.js#5291
vercel/next.js#5598 (comment)
vercel/next.js#5264 (comment)

from adaptive-loading.

anton-karlovskiy avatar anton-karlovskiy commented on May 31, 2024

@addyosmani

According to Lighthouse, Roboto font was one of the potential savings in order to improve the performance.
So we've ended up using Arial for now.

from adaptive-loading.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.