Giter Club home page Giter Club logo

Comments (5)

hrmtsh2 avatar hrmtsh2 commented on June 7, 2024

Realised that many samples already use commands (albeit not custom commands). Closing issue

from chrome-extensions-samples.

kalpanmukherjee avatar kalpanmukherjee commented on June 7, 2024

hi @hrmtsh2, could you point me towards any of these samples? much appreciated

from chrome-extensions-samples.

hrmtsh2 avatar hrmtsh2 commented on June 7, 2024

Well, coming back to this issue, I have been unable to find a single sample that explicitly uses the "command" property in the manifest (I swear I saw many when I closed the issue!). Even if there were, it was certainly small in number, and many samples do not, in fact, demonstrate the commands API.
I suppose one could do this by either incorporating it into existing samples, or by creating a new (set of) api-samples for it.
So I will reopen this issue.

from chrome-extensions-samples.

oliverdunk avatar oliverdunk commented on June 7, 2024

Hi @hrmtsh2, an example of an extension using the manifest declaration would be this one: https://github.com/GoogleChrome/chrome-extensions-samples/tree/main/api-samples/default_command_override

The only thing I don't see right now is an example of an extension using the getAll method. I think a new sample demonstrating that or updating an existing sample would make sense, if you want to work on something :)

from chrome-extensions-samples.

hrmtsh2 avatar hrmtsh2 commented on June 7, 2024

Sorry I was unable to find this before.
Yes, I will work on a sample demonstrating the getAll() method. My first idea was to extend the sample you've linked here to use getAll() in two ways:-

  1. To display all shortcuts in the extension popup (will be extending the sample you linked above with a couple more shortcuts and a popup)
  2. To check for unassigned shortcuts (this case could arise when two extensions attempt to register the same shortcuts) as is demonstrated in the docs

from chrome-extensions-samples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.