`npm test` should include sample tests about nodejs-storage HOT 7 CLOSED

Alternatively, it could be set up as a separate step of the CircleCI workflow.

from nodejs-storage.

npm test only runs unit tests right? If there are unit tests for the samples, then yes those should be included. Otherwise the samples' system tests should be executed on every PR and push to GitHub, using something like: #38 (comment)

from nodejs-storage.

What is the right way to only run sample unit tests from the npm test command? And will this change belong in the generator?

from nodejs-storage.

We typically do it as follows:

• npm run unit-test - Runs the unit tests
• npm run system-test - Runs the system tests
• npm test - Runs both the unit tests and the system tests

If there is no unit-test script in the samples' package.json, then there are no unit tests.

from nodejs-storage.

Thanks. And the generator stays out of rootDir/package.json and we should write these ourselves? I know we call through to repo-tools in some places. Is there room to integrate with it for this task?

Additionally, I think unit-test should always exist, so we can run it without npm errors. Seeing "0/0 tests passed" is acceptable.

from nodejs-storage.

These scripts would be defined in samples/package.json, which is mostly copied over from nodejs-docs-samples. If there aren't unit tests, we could have: "unit-test": "node -e \"console.log('No tests')\"", which is cross platform.

from nodejs-storage.

It seems that whatever we have now is working.

from nodejs-storage.