Comments (7)
Alternatively, it could be set up as a separate step of the CircleCI workflow.
from nodejs-storage.
npm test
only runs unit tests right? If there are unit tests for the samples, then yes those should be included. Otherwise the samples' system tests should be executed on every PR and push to GitHub, using something like: #38 (comment)
from nodejs-storage.
What is the right way to only run sample unit tests from the npm test command? And will this change belong in the generator?
from nodejs-storage.
We typically do it as follows:
npm run unit-test
- Runs the unit testsnpm run system-test
- Runs the system testsnpm test
- Runs both the unit tests and the system tests
If there is no unit-test
script in the samples' package.json, then there are no unit tests.
from nodejs-storage.
Thanks. And the generator stays out of rootDir/package.json and we should write these ourselves? I know we call through to repo-tools in some places. Is there room to integrate with it for this task?
Additionally, I think unit-test should always exist, so we can run it without npm errors. Seeing "0/0 tests passed" is acceptable.
from nodejs-storage.
These scripts would be defined in samples/package.json
, which is mostly copied over from nodejs-docs-samples
. If there aren't unit tests, we could have: "unit-test": "node -e \"console.log('No tests')\""
, which is cross platform.
from nodejs-storage.
It seems that whatever we have now is working.
from nodejs-storage.
Related Issues (20)
- FileMetadata type missing null on metadata for delete HOT 1
- The build failed HOT 2
- GetServiceAccountOptions missing projectIdentifier field
- Unable to generate signedUrl when using WIF under GKE HOT 11
- File.from picks up incorrect bucket name from passed URL HOT 3
- FR: Support HNS enablement in bucket metadata
- CreateBucketRequest type is misaligned with JSON API
- storage HMAC keys: should get metadata for an HMAC key failed HOT 2
- storage HMAC keys: should make the key INACTIVE failed HOT 2
- tests: move HMAC system tests to use emulator
- storage bucket hierarchical namespace: should create a bucket without hierarchical namespace enabled (explicit) failed HOT 1
- Missing interface's property HOT 4
- storage HMAC keys: should delete the key failed
- Signed URL prefix HOT 1
- preconditions not working HOT 2
- File.save sometimes returns a Promise that never rejects or resolves HOT 10
- storage HMAC keys: should delete the key failed HOT 2
- File.save() with a Uint8Array fails HOT 9
- Methods that perform a fetch should throw any socket errors directly (ECONNRESET) HOT 12
- storage HMAC keys: should make the key INACTIVE failed HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nodejs-storage.