Logging: How to change BundleOptions about nodejs-logging-bunyan HOT 14 CLOSED

/cc @lukesneeringer @stephenplusplus

from nodejs-logging-bunyan.

@lukesneeringer is there anyone we can ask from the google-gax repo? @landrito?

It appears the only option you can pass through on the request is: isBundling, which can only disable the previously hard-coded setting. I'm not sure that there's a way to override it at runtime.

Additionally/alternatively, maybe we should be using a better default value in the hardcoded file?

from nodejs-logging-bunyan.

Any updates or ideas on this?

from nodejs-logging-bunyan.

Calling @alexander-fenster :)

from nodejs-logging-bunyan.

@landrito to comment :)

from nodejs-logging-bunyan.

Hm. I filed an issue in gax-nodejs to see if dynamically setting the bundling at call time makes sense. I have a hunch that introducing the ability to override it at call time is going to introduce a lot of complexity (what do we do for calls made prior to dynamically changing the bundling, what to do for calls with different

@stephenplusplus do you think dynamically setting this at client instantiation would work to resolve this?

from nodejs-logging-bunyan.

Those concerns make sense to me. I guess we wouldn't want to open up the setting at the method level, but during instantiation of the client. If there's anything else gax uses similar to BundlingConfig, we would want to make sure those could be passed through as well.

from nodejs-logging-bunyan.

So overriding the bundle options should work at client initialization like so:

const Logging = require('@google-cloud/logging');

const clientConfigOverride = {
  "interfaces": {
    "google.logging.v2.LoggingServiceV2": {
      "methods": {
        "WriteLogEntries": {
          "bundling": {
            "element_count_threshold": {Your},
            "request_byte_threshold": {Overrides},
            "delay_threshold_millis": {Here}
          }
        }
      }
    }
  }
};

const logging = new Logging({
  clientConfig: clientConfigOverrde
});

Looking at how the logging-bunyan client is implemented, it passes the constructor opts to the logging client directly. So passing the clientConfig to the constructor of the logging-bunyan client should yield overridden bundling options.

from nodejs-logging-bunyan.

Oh, that looks like a good enough solution to me. @FalconerTC what do you think?

from nodejs-logging-bunyan.

This is perfect. Exactly what I am looking for. Thanks for the help.

from nodejs-logging-bunyan.

Great. I think what we need to do now is add a mention to the docs that this type of configuration is possible. @landrito is there something on the gax docs we can link to?

from nodejs-logging-bunyan.

@landrito Friendly ping.

from nodejs-logging-bunyan.

@DominicKramer I would suggest moving the issue (using the issue mover) to the gax-repo as the outstanding task is to update the docs.

from nodejs-logging-bunyan.

This issue was moved to googleapis/gax-nodejs#256

from nodejs-logging-bunyan.