Convert API to use GAPIC about nodejs-bigtable HOT 11 CLOSED

I found out that GAPIC would upgrade our protobufjs dependency from 5.* to 6.*, which should give us massive performance gains. I'm looking forward to this change.

from nodejs-bigtable.

Working on it.

from nodejs-bigtable.

@kolodny I'm happy to do this conversion effort whenever the time is right, so it follows the patterns of our other APIs that have converted (there are some gotchas, like pre-processing requests and streams for {{projectId}} placeholders, and allowing GAX's callOptions parameter through). Updating to GAPIC shouldn't have any breaking changes, but before going GA, I'll do a quick run-through of the API to confirm.

I believe we started talking about the conversion after this request: googleapis/google-cloud-node#2763 have you found a workaround or otherwise demoted that issue in terms of priority? As it stands, request interceptors are not available with either the GrpcService class or GAPIC/gax.

from nodejs-bigtable.

Are we ready to switch over yet?

from nodejs-bigtable.

We'll be ready once #27 is merged.

from nodejs-bigtable.

Hey guys, any updates on this? Since #27 is merged.

from nodejs-bigtable.

@alexander-fenster could you generate us some GAPIC code?

from nodejs-bigtable.

Hey @alexander-fenster, I believe we need code generated for the Admin APIs as well: https://github.com/googleapis/nodejs-bigtable/tree/master/protos/google/bigtable/admin/v2

from nodejs-bigtable.

Will do that.

from nodejs-bigtable.

@alexander-fenster, what's the story with admin?

from nodejs-bigtable.

from nodejs-bigtable.