Using %d instead of %s for formating in checkArgument about java-storage HOT 2 CLOSED

@runevalle-cognite i dont think so we need to add %s instead of %d, because with the %d format specifier, you can use an argument of all integral types including byte, short, int, long and BigInteger. you can see here argument position is long.

from java-storage.

@athakor
Yes, if it had been the standard formater that had been used, %d would have worked, however that is not the case in guava Preconditions.

Part of stack trace that lead to the discovery of this bug:
com.google.cloud.storage.StorageException: java.lang.IllegalArgumentException: Position should be non-negative, is %d [-1] at com.google.cloud.storage.StorageException.translateAndThrow(StorageException.java:74) at com.google.cloud.storage.BlobReadChannel.read(BlobReadChannel.java:141)

Outline of to reproduce:

• Establish a channel to a google storage bucket.
• channel.seek(-1);
• channel.read(buffer)

Documentation for guava:
https://guava.dev/releases/19.0/api/docs/com/google/common/base/Preconditions.html#checkArgument(boolean,%20java.lang.String,%20java.lang.Object...)

Relevant source code line in the formater that is actually used:
https://github.com/google/guava/blob/master/guava/src/com/google/common/base/Strings.java#L276

from java-storage.