Comments (4)
https://codereview.appspot.com/165750043/
from google-cloud-go.
I completely agree that the http status code 400 is wrong when there's no message.
However, I think this should be rolled back, or we should add error details to the returned error, because you'll get http status code 400 for other reasons. The simple test case is that you can issue a PullWait call with an empty "" subscription.
At least with the old code, you can distinguish those errors by the error details, but now you can not.
from google-cloud-go.
Ping
from google-cloud-go.
This was fixed in e2fbd20 (ErrPullTimeout was removed).
Notes:
- the underlying API no longer returns a 400 on timeout.
- the Pull and PullWait methods are deprecated in favour of Subscription.Pull. The Iterator returned by Subscription.Pull will block until a message is available or the supplied context is cancelled.
from google-cloud-go.
Related Issues (20)
- spanner: TestIntegration_InitSessionPool failed HOT 1
- bigquery: Timestamps no longer returned in UTC by default HOT 3
- logging/logadmin: TestUpdateSink failed HOT 1
- retail: paginated request to list product is returning all items HOT 3
- spanner: SelectAll does not use the same field matching rules as Row.ToStruct
- bigtable: TestIntegration_PartialReadRows failed HOT 1
- bigtable: TestIntegration_LargeReadsWritesAndScans failed HOT 1
- auth: support detecting default google access ID
- storage: make it possible to disable Content-Type sniffing HOT 1
- spanner: allow to bind spanner.Statement to a placeholder HOT 4
- firestore: iterator timeout issue with non-existent document reference HOT 1
- pubsub: With exactly once delivery and message ordering enabled, message order is not mantained HOT 4
- profiler: high memory usage leading to OOM HOT 5
- pubsublite/internal/wire: TestAssigningSubscriberAddRemovePartitions failed HOT 1
- renovate: disable Go runtime version updates
- pubsub: TestIntegration_OrderedKeys_ResumePublish failed HOT 2
- bigtable: rowFilter.String() v1.21.0 do not include quotes in the endBound part HOT 1
- bigquery: TestIntegration_InsertErrors failed HOT 9
- spanner: SelectAll does not correctly handle structs with spanner tag annotations that contain uppercase letters HOT 1
- datastore: Timestamp seconds exceeds limit for field HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-cloud-go.