Comments (4)
milinddethe15
commented on June 18, 2024
Hi @danielbankhead, I would like to work on this. If I understood the issue, I just have to remove extends RefreshOptions from
export interface OAuth2ClientOptions extends RefreshOptions {
clientId?: string;
clientSecret?: string;
redirectUri?: string;
credentials?: Credentials;
}
from google-auth-library-nodejs.
danielbankhead
commented on June 18, 2024
Hey @milinddethe15, good question - after #1663 has been merged the RefreshOptions interface itself can be removed.
from google-auth-library-nodejs.
milinddethe15
commented on June 18, 2024
Hi, I want to work on this issue. Assign me.
from google-auth-library-nodejs.
danielbankhead
commented on June 18, 2024
@milinddethe15 done! Take your time as this refactor is a breaking change and we won’t release another major for some time.
from google-auth-library-nodejs.
Related Issues (20)
- OAuth2Client verifyIdToken response 403 forbidden using ipv6 HOT 3
- refactor!: Remove `additionalOptions` from AuthClients HOT 2
- refactor!: Remove `DEFAULT_UNIVERSE` from `BaseExternalClient`
- refactor!: Remove `envDetect.ts` and utilize `gcp-metatada`'s utilities
- feat!: Normalize `#scopes` args and properties to `string[]`
- feat!: Normalize `GoogleAuth<T>` to `AuthClient`
- pack and install: "after each" hook: cleanup staging for "should be able to webpack the library" failed
- feat: Provide Mechanism to Change AuthClient Scopes Uniformly
- chore: Clean-up Documentation for Mapped SnakeCased Properties
- refactor!: Remove `Transporter` and `DefaultTransporter` from `GoogleAuth` class HOT 2
- ECONNRESET HOT 5
- JWT Class import issue HOT 9
- googleauth googleauth: many tests failed HOT 3
- googleauth googleauth getUniverseDomain: should use the metadata service if on GCP failed HOT 3
- TypeError: gpcMetadata.universe is not a function with 9.3.0 after upgrade from 9.2.0 (with google-gax) on cloud run HOT 1
- CloudRun issue after upgrading to version 9.3.0 HOT 2
- Unsuccessful response status code. Request failed with status code 404 HOT 14
- Request for web platform library HOT 1
- pack and install: "after each" hook: cleanup staging for "should be able to webpack the library" failed HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-auth-library-nodejs.