Giter Club home page Giter Club logo

Comments (7)

atjeff avatar atjeff commented on May 24, 2024

@JustinBeckwith any movement on this one?

from gaxios.

JustinBeckwith avatar JustinBeckwith commented on May 24, 2024

nope

from gaxios.

atjeff avatar atjeff commented on May 24, 2024

@JustinBeckwith would you accept a PR?

from gaxios.

JustinBeckwith avatar JustinBeckwith commented on May 24, 2024

I'm curious - what is the use case around this? I think someone made the same change in retry-axios, on which this retry logic was based. I just can't for the life of me figure out what you would that needed to be async in here 😆

The challenge here will be writing it in a way that isn't a breaking change. Or, we should lump the change in with the node.js 8 deprecation. Assuming we've figured all that stuff out, always love a PR!

from gaxios.

atjeff avatar atjeff commented on May 24, 2024

For me, I want to be able to detect that an OAuth2 token has been invalidated, and refresh it before retrying the request

from gaxios.

JustinBeckwith avatar JustinBeckwith commented on May 24, 2024

Ahhh, that actually makes sense! We do a similar thing in our auth libraries. PR would be lovely :)

from gaxios.

atjeff avatar atjeff commented on May 24, 2024

Thanks @JustinBeckwith ! I opened a PR, I didn't see that I broke any tests.

from gaxios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.