Giter Club home page Giter Club logo

Comments (9)

Artoria2e5 avatar Artoria2e5 commented on May 3, 2024 1

I think #22 is supposed to fix this.

from zx.

SilurianYang avatar SilurianYang commented on May 3, 2024

@Artoria2e5 I try

from zx.

SilurianYang avatar SilurianYang commented on May 3, 2024

I think #22 is supposed to fix this.

Succeeded

from zx.

antonmedv avatar antonmedv commented on May 3, 2024

Done.

from zx.

Artoria2e5 avatar Artoria2e5 commented on May 3, 2024

I don't think it's done. The offending path = join(process.cwd(), firstArg) code is still present and messing with Windows.

from zx.

antonmedv avatar antonmedv commented on May 3, 2024

#45

from zx.

MarkosKon avatar MarkosKon commented on May 3, 2024

I don't think it's done. The offending path = join(process.cwd(), firstArg) code is still present and messing with Windows.

It would break something if that line changed to path = resolve(firstArg)?

My problem was different, though. I was trying to execute a zx file from path (on Windows with Git bash), and this change solved it.

from zx.

antonmedv avatar antonmedv commented on May 3, 2024

Awesome. Lets create pr with it. And test if possible.

from zx.

MarkosKon avatar MarkosKon commented on May 3, 2024

Awesome. Lets create pr with it. And test if possible.

I can make the above change and write a test that executes a new script from the PATH variable if you want.

The problem is that zx on Linux can already execute a script from PATH, from what I see. The test may also pass on my local Windows machine, but how do we write a test that succeeds on Windows with Git bash (with GitHub actions)?

from zx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.