Comments (7)
flagxor
commented on May 18, 2024
1
Sounds like thomasmcneill has this implement here:
https://github.com/thomasmcneill/wwwbasic/commits?author=thomasmcneill
from wwwbasic.
flagxor
commented on May 18, 2024
It looks like your changes are actually on master of your branch, which sound be mergeable.
It should work to create another pull request against master.
You want it to look like this:
https://pasteboard.co/HFjPsKk.png
That should be the default if you click 'pull request' under the clone and download button from here:
https://github.com/thomasmcneill/wwwbasic
from wwwbasic.
thomasmcneill
commented on May 18, 2024
I can cut and paste them anywhere. It's just a few functions and a few
vars up top.
Whatever is easier for you.
…On Mon, Sep 24, 2018 at 12:43 AM Brad Nelson ***@***.***> wrote:
It looks like your changes are actually on master of your branch, which
sound be mergeable.
It should work to create another pull request against master.
You want it to look like this:
https://pasteboard.co/HFjPsKk.png
That should be the default if you click 'pull request' under the clone and
download button from here:
https://github.com/thomasmcneill/wwwbasic
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#35 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AOPhs2_Vq-EB5Pm66yWarIQgf0SHW-1wks5ueGLjgaJpZM4W2DJ7>
.
from wwwbasic.
flagxor
commented on May 18, 2024
Hi Thomas,
Looking at your branch more closely, there's a few licensing issues we'd need to sort through before merge (to keep the lawyercats at bay :-). See below.
I'll happy to rework things as you've done the hard part of getting it running!
Unless you'd rather?
I've also figured out how to create a PR with your master changes and then override the CLA bot.
- For the note frequencies, the license/copyright notice on the page seems to forbid copying (as opposed to linking): https://pages.mtu.edu/~suits/PofMCopyRight.html
- Calculating the note frequencies can just be done with Math.pow(2, n/12) * 110 or some such, so we can likely substitute a formula.
- For the PLAY docs, they fall under CC-3.0, https://creativecommons.org/licenses/by-sa/3.0/, that carries different limits than Apache, so it might be better to link to that rather than inline.
- The sample with PLAY has something similar. We could put it in third_party, but that seems tedious. Alternatively, I'm sure I can come up with an unencumbered jingle for the example.
I'll likely get cycles to do this closer to the weekend.
Cheers
-BradN
from wwwbasic.
thomasmcneill
commented on May 18, 2024
I posted the documentation in there just so I had it while I was working on
it. The frequencies are pretty commonly known. Multiple charts from
multiple sites had the same information.
Wikipedia has the chart.
https://en.wikipedia.org/wiki/Piano_key_frequencies
I'll remove the inline notes for myself.
And I actually have somes stuff I wrote years ago. There is always Mary
had a Little lamb. Quick search shows it is public domain.
…On Tue, Sep 25, 2018 at 7:53 PM Brad Nelson ***@***.***> wrote:
Hi Thomas,
Looking at your branch more closely, there's a few licensing issues we'd
need to sort through before merge (to keep the lawyercats at bay :-). See
below.
I'll happy to rework things as you've done the hard part of getting it
running!
Unless you'd rather?
I've also figured out how to create a PR with your master changes and then
override the CLA bot.
- For the note frequencies, the license/copyright notice on the page
seems to forbid copying (as opposed to linking):
https://pages.mtu.edu/~suits/PofMCopyRight.html
- Calculating the note frequencies can just be done with
Math.pow(2, n/12) * 110 or some such, so we can likely substitute a formula.
- For the PLAY docs, they fall under CC-3.0,
https://creativecommons.org/licenses/by-sa/3.0/, that carries
different limits than Apache, so it might be better to link to that rather
than inline.
- The sample with PLAY has something similar. We could put it in
third_party, but that seems tedious. Alternatively, I'm sure I can come up
with an unencumbered jingle for the example.
I'll likely get cycles to do this closer to the weekend.
Cheers
-BradN
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#35 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AOPhs9YUlllvjU9sga3npTdrD1OMtrlHks5uesIMgaJpZM4W2DJ7>
.
from wwwbasic.
pagetelegram
commented on May 18, 2024
Looking forward to sound implementation as well. Hope you work it out.
Example program (for now):
http://aleatoryrecords.com/
from wwwbasic.
thomasmcneill
commented on May 18, 2024
I'll be able to update it soon. I have been swamped. I'll get out all the
documentation I put in it that's from other sources and go with a log table
for frequencies or something more open source friendly.
…On Mon, Dec 17, 2018 at 5:30 PM Page Telegram ***@***.***> wrote:
Looking forward to sound implementation as well. Hope you work it out.
Example program (for now):
http://aleatoryrecords.com/
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#35 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AOPhs9eSfTveTpsPjsGZRCXg0iWYTWgAks5u6BrtgaJpZM4W2DJ7>
.
from wwwbasic.
Related Issues (20)
- Support for BASIC dialects HOT 4
- Implement ON x GOTO a,b,c,d HOT 5
- Add a copyright header check. HOT 1
- Some issues found by static analyzer HOT 3
- Implement error on out of bounds array access.
- Better error handling for FUNCTION/SUB/GOSUB/RETURN clashes + underflow. HOT 3
- ON GOSUB may be slightly off. HOT 3
- Handle touch screen input better.
- Some Guidance on The Why? HOT 3
- Support GORILLAS.BAS HOT 2
- Emulate EGA/VGA PALETTE + CGA Background HOT 1
- Support the ANY type properly HOT 1
- Support EGA/VGA Text 8x14 / 9x16
- Set the input focus in the browser HOT 1
- Add waffle.io project management
- Changing tabs flips wwwBasic window upside down HOT 1
- Basic Anywhere Machine
- A suggested bug-fix for the "swap" statement HOT 1
- BASIC Anywhere Machine: enhancements to internal copy of wwwBASIC
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wwwbasic.