Consider using [!NOTE] blockquote for browser/platform compatibility notes about webcrypto.dart HOT 10 CLOSED

@jonasfj Changed all "Remark" notes to use the [!NOTE] format.

1. https://pub.dev/documentation/webcrypto/latest/webcrypto/AesCtrSecretKey/encryptBytes.html, https://pub.dev/documentation/webcrypto/latest/webcrypto/AesCtrSecretKey/decryptBytes.html, https://pub.dev/documentation/webcrypto/latest/webcrypto/AesCtrSecretKey/encryptStream.html,
   https://pub.dev/documentation/webcrypto/latest/webcrypto/AesCtrSecretKey/decryptStream.html
   
   

2. https://pub.dev/documentation/webcrypto/latest/webcrypto/EllipticCurve.html
   
   

3. https://pub.dev/documentation/webcrypto/latest/webcrypto/AesGcmSecretKey/encryptBytes.html
   
   

If this works, I can proceed to create a PR.

from webcrypto.dart.

Fixed in #126

@TropicolX pro tip: If you write Fixed #115 in the description of a PR, then it'll close the associated issue when the PR is landed.

from webcrypto.dart.

Hi @jonasfj. Can I be assigned to this?

from webcrypto.dart.

Done,

from webcrypto.dart.

There is a thread about this package in the #packages channel on dart_community

https://dart.dev/community

Feel free to join and say hi.

from webcrypto.dart.

Alright, thanks!
Will do

from webcrypto.dart.

Hi @jonasfj,
How do I test out the changes locally? Can I get a preview UI similar to this: https://pub.dev/documentation/webcrypto/latest/webcrypto/AesCtrSecretKey/encryptBytes.html

from webcrypto.dart.

Run dartdoc

See: https://pub.dev/packages/dartdoc

from webcrypto.dart.

(1) is perfect, that's what I imagined this bug would address.

But (2) and (3) also seem appropriate.

Unrelated, but in the case of (2), I asked around and it was suggested that if we gave the enum a private member. Then people wouldn't be able to switch over it without having a default case.

This is unrelated, but we should consider adding a private member to discourage people from making the assumption that new values won't be added in the future.

from webcrypto.dart.

Hi @jonasfj, thanks for the review.
I've created a PR for the issue here #126

Regarding the enum, I have no idea how to add a private member to an enum in dart 😅 but I'd love to look into it. Any pointers on how to do this would also be appreciated.

from webcrypto.dart.