Unit tests are running slow / CI takes a long time. about weather-tools HOT 4 CLOSED

@alxmrs This is caused by these two tests and the exponential backoff here

I'm thinking of overriding some of the defaults for the tests only, sound good?

Edit: I feel like ValueError shouldn't be triggering retry_filter=retry.retry_on_server_errors_and_timeout_filter

This might be what we're after...

from weather-tools.

@alxmrs Seems to be back in business 🐢 🐇
https://github.com/google/weather-tools/runs/4860959961?check_suite_focus=true

from weather-tools.

Thanks Cillian! Marking as closed.

from weather-tools.

Great investigation! It makes sense that retries are causing the delay.

I looked at Apache Beam's filter definition, and I don't understand why a value error would cause retries. I wonder if the underlying GCS File IO modules are wrapping the exceptions. Does your fix from the edit save time in practice?

from weather-tools.