Comments (3)
Note making vroom tests too conditional could quickly get out of hand, with long vroom files being so linear and stateful. Might decide a feature like this would be too hard to get right and not worth building.
An alternative that's already supported is to keep all the conditional stuff in separate files and have the test runner scripts conditionally --skip
files they don't support. maktaba does that with vroom/system-vimjob.vroom, for example: https://github.com/google/vim-maktaba/blob/f2abdd19a/.travis.yml#L23.
from vroom.
Counter proposal: @skipif
is only valid as the first directive in the file.
It would be really handy to be able to point vroom --crawl
at a directory and not have to figure out ahead of time which tests are going to be valid. Putting it into a directive also gives the option of having vroom give a report of skipped tests, which would be useful for determining if test coverage is sufficient (or could let you know that your vim version isn't what you expected).
Making it only valid as the first directive encourages test decomposition, and also greatly simplifies the interpreter as it can just stop immediately. It would also be simple to implement the directive as "skip the rest of the file". I would be very opposed to vroom guessing where to resume tests (if @skipif
were per-test) because beginning/end of a test is kind of ambiguous. It would need a corresponding @resume
or something, and that just gets messy for writing tests.
from vroom.
Ooh, yeah, I'd thought about doing it as an early exit mechanism but not about making it just a file-level directive.
from vroom.
Related Issues (20)
- Rewrite neovim_mod.py to use neovim's remote screen facility HOT 3
- Vroom tests hanging on Vim versions 7.4.1594 to 7.4.1657 HOT 5
- Vroom is using settings in ftplugin/ directory HOT 5
- v0.12.0 release doesn't work with current NeoVim HOT 4
- Add an option to trigger vim verbosefile logging
- System hijacks failing when using python 3.7 HOT 7
- Vroom fails in non-ANSI terminals with errors about missing color constants
- Require explicit opt-in to run shell commands for real HOT 2
- Unusable since Neovim 0.8 HOT 6
- Update from Travis to GH Actions
- Vroom needs a logo / icon HOT 10
- Travis neovim builds timing out HOT 12
- Empty maktaba#buffer#Overwrite() sometimes hangs vroom
- Provide a simple reference to vroom syntax HOT 1
- Support for redir in vroom tests HOT 8
- Consider waiting a small extra delay for each syscall on commands with multiple syscalls
- Remove stderr output channel
- Parsing @do arguments is broken HOT 1
- Support bleeding-edge vim in Travis test matrix HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vroom.