Giter Club home page Giter Club logo

Comments (6)

asparsa avatar asparsa commented on July 28, 2024

I saw the other issue with the same problem!
I checked and it works with ninja, but I wanted to see if it is only creating the directory issue. So I created the directory it was saying it's not there. I created 38 paths in total and the make was complete!
I still wonder why ninja can create those paths and make won't!

from tensorstore.

laramiel avatar laramiel commented on July 28, 2024

What are the paths you had to create? We could have bazel_to_cmake.py create those paths.
Look at https://github.com/google/tensorstore/tree/master/tools/cmake/bazel_to_cmake

Closing this as a duplicate of #151

from tensorstore.

asparsa avatar asparsa commented on July 28, 2024

I didn't save all of them but here are some example:
/u/asalimiparsa/test/build/_deps/udpa-build/10e5d71e/: No such file or directory
/u/asalimiparsa/test/build/_deps/envoy-build/d7d341d5/: No such file or directory
/u/asalimiparsa/test/build/_deps/envoy-build/12ec1b73/

/u/asalimiparsa/test/build/_deps/udpa-build/18a61f37/
/u/asalimiparsa/test/build/_deps/envoy-build/3ffcac10/
/u/asalimiparsa/test/build/_deps/envoy-build/b2a2733a/
/u/asalimiparsa/test/build/_deps/envoy-build/88915a3b/
/u/asalimiparsa/test/build/_deps/udpa-build/2fc9b2a5/

from tensorstore.

laramiel avatar laramiel commented on July 28, 2024

Ok, I suspect that I know what's going on here. These are "hashed" output directories used in some protoc paths.

I think that when out_hash is set here:

Then we need to emit file(MAKE_DIRECTORY {output_dir})

from tensorstore.

asparsa avatar asparsa commented on July 28, 2024

Yeah, you were right. I added file(MAKE_DIRECTORY {output_dir}) to its return to make those directories.
I tested it with make and ninja, both work well. I can pull request for that.

from tensorstore.

laramiel avatar laramiel commented on July 28, 2024

I have already submitted a fix for this in 22a2396

from tensorstore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.