Implement settings view screen for RRM about site-kit-wp HOT 6 CLOSED

QA Update ✅

Thanks @hussain-t .

All 3 variations were verified and they are appearing accordingly:

• Without the notice ✅

  

• With the notice 'Your publication is still awaiting review. You can check its status in Reader Revenue Manager.' ✅

  

• With the notice 'Your publication requires further setup in Reader Revenue Manager' ✅

  

As for the Clarification 2, I've raised another ticket separately here: #9144

As for this ticket, it's good to move to Approval.

from site-kit-wp.

Thank you for the IB, @ankitrox ! Please take a look at my comments below:

• Return a div container with googlesitekit-setup-module class name which should wrap following element.

An additional class name specific to the module would be nice to add, i.e. googlesitekit-setup-module--reader-revenue-manager.

• A heading Publication and text which should be the publication ID. Note that the heading is smaller than the ID text. Please refer to the figma design. These both elements should be wrapped within a single div.

Using the appropriate class names and components in crucial here. Let's mention using the wrapper div to use the googlesitekit-settings-module__meta-item class, which should also have another wrapper div with the class googlesitekit-settings-module__meta-items.

The setting label should be an h5 with the class name googlesitekit-settings-module__meta-item-type and the setting value should be a p with the class name googlesitekit-settings-module__meta-item-data, that renders a DisplaySetting component with the publication ID.

It may also be beneficial to reference another module's SettingsView component to get an idea of the structure, e.g. assets/js/modules/analytics-4/components/settings/SettingsView.js. Using the appropriate markup is crucial to ensure a consistent structure.

Please let me know if you have any questions, thank you!

from site-kit-wp.

Thank you @nfmohit . I've updated the IB as per mentioned points.

from site-kit-wp.

Thank you @ankitrox . I've made some minor linguistic improvements to the IB, it looks good to me 👍

IB ✅

from site-kit-wp.

QA Update ⚠️

This is good overall. I was able to run the script and the settings view screen looks like Figma with the correct styling to align with existing styling.

I have 2 clarifications though:
CLARIFICATION 1: ⚠️
There are 3 variations of the settings view screen:

1. Without the notice
2. With the notice 'Your publication is still awaiting review. you can check its status in Reader Revenue Manager.'
3. With the notice 'Your publication requires further setup in Reader Revenue Manager'

Currently, I can only get the 3rd variation.
Could you guide me on how to setup and review the 1st and 2nd variations please?

CLARIFICATION 2: ⚠️
This is out of scope for this ticket but checking in case we need to create another ticket or it's being handled in an existing ticket.
When I click on the '[See full details in Reader Revenue Manager]' link, I get routed to a page hitting 400 error.
The error page is attached.

from site-kit-wp.

Hi @kelvinballoo,

There are 3 variations of the settings view screen:

Please use the tester plugin to change the publication onboarding state. I have updated the QAB.

CLARIFICATION 2: ⚠️
This is out of scope for this ticket but checking in case we need to create another ticket or it's being handled in an existing ticket.
When I click on the '[See full details in Reader Revenue Manager]' link, I get routed to a page hitting 400 error.
The error page is attached.

This is a bug. However, as you said, it's out of the scope. Feel free to create a new ticket.

from site-kit-wp.