Comments (6)
QA Update ✅
Thanks @hussain-t .
All 3 variations were verified and they are appearing accordingly:
-
Without the notice ✅
-
With the notice 'Your publication is still awaiting review. You can check its status in Reader Revenue Manager.' ✅
-
With the notice 'Your publication requires further setup in Reader Revenue Manager' ✅
As for the Clarification 2, I've raised another ticket separately here: #9144
As for this ticket, it's good to move to Approval.
from site-kit-wp.
Thank you for the IB, @ankitrox ! Please take a look at my comments below:
- Return a
div
container withgooglesitekit-setup-module
class name which should wrap following element.
An additional class name specific to the module would be nice to add, i.e. googlesitekit-setup-module--reader-revenue-manager
.
- A heading
Publication
and text which should be the publication ID. Note that the heading is smaller than the ID text. Please refer to the figma design. These both elements should be wrapped within a singlediv
.
Using the appropriate class names and components in crucial here. Let's mention using the wrapper div
to use the googlesitekit-settings-module__meta-item
class, which should also have another wrapper div
with the class googlesitekit-settings-module__meta-items
.
The setting label should be an h5
with the class name googlesitekit-settings-module__meta-item-type
and the setting value should be a p
with the class name googlesitekit-settings-module__meta-item-data
, that renders a DisplaySetting
component with the publication ID.
It may also be beneficial to reference another module's SettingsView
component to get an idea of the structure, e.g. assets/js/modules/analytics-4/components/settings/SettingsView.js
. Using the appropriate markup is crucial to ensure a consistent structure.
Please let me know if you have any questions, thank you!
from site-kit-wp.
Thank you @nfmohit . I've updated the IB as per mentioned points.
from site-kit-wp.
Thank you @ankitrox . I've made some minor linguistic improvements to the IB, it looks good to me 👍
IB ✅
from site-kit-wp.
QA Update ⚠️
This is good overall. I was able to run the script and the settings view screen looks like Figma with the correct styling to align with existing styling.
__________________________________________________________________I have 2 clarifications though:
CLARIFICATION 1:
There are 3 variations of the settings view screen:
- Without the notice
- With the notice 'Your publication is still awaiting review. you can check its status in Reader Revenue Manager.'
- With the notice 'Your publication requires further setup in Reader Revenue Manager'
Currently, I can only get the 3rd variation.
Could you guide me on how to setup and review the 1st and 2nd variations please?
CLARIFICATION 2:
This is out of scope for this ticket but checking in case we need to create another ticket or it's being handled in an existing ticket.
When I click on the '[See full details in Reader Revenue Manager]' link, I get routed to a page hitting 400 error.
The error page is attached.
from site-kit-wp.
Hi @kelvinballoo,
There are 3 variations of the settings view screen:
Please use the tester plugin to change the publication onboarding state. I have updated the QAB.
CLARIFICATION 2:
⚠️
This is out of scope for this ticket but checking in case we need to create another ticket or it's being handled in an existing ticket.
When I click on the '[See full details in Reader Revenue Manager]' link, I get routed to a page hitting 400 error.
The error page is attached.
This is a bug. However, as you said, it's out of the scope. Feel free to create a new ticket.
from site-kit-wp.
Related Issues (20)
- Creation of `Top cities driving purchases` ACR KMW
- Creation of `Top cities driving purchases` ACR KMW
- Creation of `Top device driving purchases` ACR KMW
- Creation of `Top device driving purchases` ACR KMW
- Creation of `Top traffic source driving purchases` ACR KMW
- Glitches / errors when changing the audience selection in mobile viewports
- Impossible to stop tagmanager code placement HOT 1
- Agency with hundreds of client Google Analytics accounts unable to assign correct profiles HOT 2
- Remove `conversionInfra` feature flag
- Remove localization for module homepage URLs
- Improve the `resetPublications` action HOT 6
- Requests made for module settings on dashboard
- Implement Internal Measurement/Tracking Following ACR KMW Updates
- Enhance compatibility with Docker locally for E2E
- Refactor the `ZeroDataNotification` to use the new lighter `Notification` component. HOT 2
- Release 1.134.0
- Add "Edit in Reader Revenue Manager" link for the RRM module
- Sort Storybook menu items HOT 1
- Enhance feature activation for BC
- Revert the Fix For VRT failures
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.