Giter Club home page Giter Club logo

Comments (3)

10upsimon avatar 10upsimon commented on August 17, 2024 1

@aaemnnosttv during replacement of color variables with tokens, I noticed that some of the variables have tokens associate with them, and some not, while others are only defined in _variables.scss but not in _variables-mui3.scss. Here are said findings:

$c-neutral-n-400 // Has no color token equivalent.
$c-neutral-n-700 // Has no color token equivalent.
$c-neutral-n-66 // Has no color token equivalent.
$c-green-g-50 // Has no color token equivalent.
$c-red-600 // Only defined in assets/sass/config/_variables.scss and not in assets/sass/config/_variables-mui3.scss
$c-blue-b-500 // Has no color token equivalent.
$c-blue-b-50 // Has no color token equivalent.
$c-blue-b-600 // Has no color token equivalent.
$c-blue-b-400 // Has no color token equivalent.
$c-yellow-y-100 // Has no color token equivalent.
$c-yellow-y-600 // Has no color token equivalent.
$c-yellow-900 // Only defined in assets/sass/config/_variables.scss and not in assets/sass/config/_variables-mui3.scss
$c-violet-v-0 // Has no color token equivalent.
$c-violet-v-500 // Has no color token equivalent.

Those that had token equivalents were replaced throughout the codebase.

from site-kit-wp.

tofumatt avatar tofumatt commented on August 17, 2024

IB ✅

from site-kit-wp.

tofumatt avatar tofumatt commented on August 17, 2024

Moving directly to Approval as no QA is needed here.

from site-kit-wp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.