Comments (10)
samthor
commented on June 26, 2024
Is there any chance you can send us a fix for the other issues? Having the site work even without Closure on Windows would be a great start—there's only a handful of scenes which still use that.
My 2c, I wonder if we pass specific /'s into the Closure compiler that Windows doesn't like.
from santa-tracker-web.
SneezingCactus
commented on June 26, 2024
I'll try to find and send the fixes (I don't remember what did I edit to fix it
from santa-tracker-web.
SneezingCactus
commented on June 26, 2024
So, what I first did was add .posix to the require("path") in import-utils.js to fix the "unsupported on Windows" problem.
I also added the .posix in modern-vfs-middleware.js to fix most virtual files (like config.json) not working.
The last thing I did was removing the /st/ prefix on static paths to fix certain static js files (such as santa-error.js) going way too back and going outside /st/ in some requires, causing those required js files to not be loaded. (I'm pretty sure there's a much nicer workaround to this though)
Hope this helps!
from santa-tracker-web.
SneezingCactus
commented on June 26, 2024
Also, for some reason, the 4 background village svg layers you'd see at the start of the page are missing.
from santa-tracker-web.
SneezingCactus
commented on June 26, 2024
I fixed it! There were two problems:
Problem #1 is that santa-vfs, closure-compiler and closure-compiler-js make changes in paths, and since Windows uses \ instead of /, it breaks, so I added .posix to each require("path").
Problem #2 is that closurePlugin in santa-vfs gets the scene name and flags by the wrong m index (it uses m[1] and m[2] where it should be m[2] and m[3]), so I corrected it.
from santa-tracker-web.
samthor
commented on June 26, 2024
@SneezingCactus can you send a PR to fix this?
from santa-tracker-web.
SneezingCactus
commented on June 26, 2024
I would, but the problem is that in order to fix closure I'd have to modify closure-compiler and closure-compiler-js which are part of the google closure module, and I can't edit that (unless I can send a PR to the google closure repo)
from santa-tracker-web.
SneezingCactus
commented on June 26, 2024
I can send a PR for the other fixes though
from santa-tracker-web.
samthor
commented on June 26, 2024
I'm one of the original authors of closure-compiler-js so I can probably
help with that. :)
Although I think we are using the binary version now.
Having the non-Closure scenes work on Windows would still be great.
…On Wed, 2 Dec 2020 at 16:19, SneezingCactus ***@***.***> wrote:
I can send a PR for the other fixes though
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA5DEHE3DK7NZQ4EVVLVRLSSXE6TANCNFSM4UGWGJ2A>
.
from santa-tracker-web.
SneezingCactus
commented on June 26, 2024
Ok, I sent the PR
from santa-tracker-web.
Related Issues (20)
- Weird Reddit Post. HOT 1
- 1
- gumball tilt, penguin dash and others
- the tracker itself
- 37 Vulnerabilities when installing prerequisites HOT 1
- Where is the data for Santa's current location sourced from for the 2022 Santa Tracker? HOT 2
- codelab - lv. 10 and 11 - Jump command not working HOT 7
- Please remove 'Penguin Proof' and 'Out Like a Light' videos HOT 2
- App not appearing in Play Store. HOT 2
- Japanese "Game Over" message includes `<br>` in between
- Use the space key in the Holiday Slopes game HOT 1
- "Take Off" takes you to "Out Like a Light" HOT 2
- Penguin Dash level 9 is sometimes skipped HOT 1
- Penguin Dash level 9 sometimes skipped.
- Access to original version of elf ski HOT 2
- Elf Ski (Holiday Slopes) is broken HOT 1
- Motion games don’t work in Safari iOS 14
- Chrome iOS won't load new scenes
- Some Games Are Not Shown In The Menu, But Are Found Scrolling Down
- Codelab and Code Boogie timeout when using the fallback java compiler
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from santa-tracker-web.