Compiler: GCC-13.2 Compile Flags: <div class="highlight highl

Here's the function in its entirety: <div class="Box Box--conden

A compilation error with the flag -Werror=stringop-overread about re2 HOT 1 CLOSED

kashirin-alex commented on May 24, 2024

A compilation error with the flag -Werror=stringop-overread

from re2.

Comments (1)

junyer commented on May 24, 2024

Here's the function in its entirety:

re2/re2/re2.cc

Lines 133 to 137 in 27536b0

 static std::string trunc(absl::string_view pattern) { 

 if (pattern.size() < 100) 

 return std::string(pattern); 

 return std::string(pattern.substr(0, 100)) + "..."; 

 }

Firstly, note the if. Secondly, even without the if, the function shouldn't overread because substr() shouldn't overread no matter whether the type of pattern is absl::string_view/std::string_view or, given a sufficiently old version of RE2, re2::StringPiece.

This is a false positive from -Werror=stringop-overread, I think. If you can reproduce this issue with smaller inputs, it would presumably be worth filing a bug against GCC.

from re2.

Related Issues (20)

Failed build google-re2 on the alpine docker image HOT 2
Memory leak issue observed in RE2 HOT 3
Could not build wheels for google-re2, which is required to install pyproject.toml-based project HOT 1
[bazel] Failed to build on Emscripten HOT 5
A SEGV found in re2::DFA::CachedState(re2/re2/dfa.cc:753:40) HOT 3
Data race condition in void DFA::RWLocker::LockForWriting() HOT 2
Support for Python versions lower than 3.8 HOT 1
What is the 'sam' command used in doc scripts? HOT 2
the parser can incorrectly merge runs of literals and/or character classes
Fail on negative lookbehind regex compilation HOT 5
Question on RE2::Match latency for patterns containing a large number of match groups HOT 4
Error : name 'apple_cc_toolchain' is not defined in CI at Bazel@HEAD HOT 1
RE2::GlobalReplace case insensitive fail with OR-ed pattern AB|AC HOT 2
Error loading '@pybind11_bazel~2.11.1.bzl.2//:python_configure.bzl' in re2 2024-02-01 HOT 5
Non-greedy qualifier doesn't work with end-anchor HOT 6
Installing google-re2 using pip HOT 1
Cant get RE2::Consume to work HOT 1
SIGSEGV if `Match` is called before `Compile` HOT 5
Success but unsuppressable stderr message when compiling an empty `re2.Filter` HOT 3

A compilation error with the flag -Werror=stringop-overread about re2 HOT 1 CLOSED

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	static std::string trunc(absl::string_view pattern) {
	if (pattern.size() < 100)
	return std::string(pattern);
	return std::string(pattern.substr(0, 100)) + "...";
	}