Include relevant links in README about material-design-lite HOT 8 CLOSED

I’d like to add a gulp task for the visual tests. As of now they are really awkward to reach (i.e. not at all via the gulp provided tasks).

from material-design-lite.

SGTM.

from material-design-lite.

The above items are done, with the exception of testing. There are a few open questions here that I'd love to hear others thoughts on:

• Should we create a deployment script to populate gh-pages with the latest version of our components? It could be something manually done, or something we setup as a post-commit hook if we preferred automation.
• For testing, we will need a few libraries from node_modules in order to enable http://google.github.io/material-design-lite/test/ to work. The above script idea could do this as part of its process without having to check in modules into master.

from material-design-lite.

Should we create a deployment script to populate gh-pages

I’d be in favor of a gulp task for that

The above script idea could do this as part of its process without having to check in modules into master

Wouldn’t these node dependencies already be installed when npm install is being run? Or am I missing something?

from material-design-lite.

I’d be in favor of a gulp task for that

This is fine by me, however we should keep in mind the growth/complexity of the gulpfile here as it will be used by others who want to customise the overall MDL source.

Wouldn’t these node dependencies already be installed when npm install is being run? Or am I missing something?

No. We ignore the node_modules directory (https://github.com/google/material-design-lite/blob/master/.gitignore) as we should for master. This means these deps are not available when pushed to gh-pages without some modification. So, we need a smarter solution there I'm afraid.

from material-design-lite.

Good point. Maybe a separate script is preferrable. But we should automate the process. I feel like a commit hook is a litte too much, though.

from material-design-lite.

Now that deployment has been added in, let's close this.

@surma given the number of breakages we've noticed with the last build I would say let's hold off on updating github pages with a deployment until we think we're in a stable spot.

from material-design-lite.

Agreed

from material-design-lite.