Comments (8)
Thanks for the patch! I think you are not a Google employee. We need ask you to sign "Contributor License Agreements" to accept patches. Could you review and sign it?
https://cla.developers.google.com/clas
Also, your patch doesn't contain your name nor your email address. Could you tell me them so I can set appropriate info (or it's easier for me if you can make PRs)?
from kati.
I'm working for a company that is a Google partner. This work has been done on company time and company resources. But this is my private GitHub account, that's why I removed my company email address from the patch. If there is some other channel than GitHub for Google partners to submit fixes/improvements then please point me in the right direction.
If Github is the only channel and forking the project is the preferred method for submitting changes, then I'll have to cherry-pick the changes to the new branch with my private email address.
from kati.
I'm not familiar with our licensing policies around partners. If you want, I can ask the question internally. But yeah, if you can send a PR from your private address and sign the CLA, it's easier for me.
from kati.
I'll need to check if I'm allowed to sign the "on behalf of your employer" variant of the CLA. If not then I'll agree with my boss to submit these changes as private contributions.
from kati.
Any update? I chatted with people who are usually working with partner companies. Their answer sounded like asking you or your company to sign the CLA is the only option.
from kati.
I've initiated the necessary company internal process to get approval for upstream contributions. Stay tuned....
from kati.
Great, thanks!
from kati.
The internal process finally completed and I pushed my changes to my fork. Please have a look at the cumulative PR #58.
from kati.
Related Issues (20)
- Create packages for different distros.
- The root of the repo is untidy mess HOT 2
- status of recursive make? HOT 2
- feature request: -C flag HOT 1
- Find emulator unnecessarily greedy HOT 4
- Why using c++ instead of go? HOT 2
- Two recursive variables referencing each other cause a segfault HOT 1
- Dependency loops cause targets to be missing from ninja graph with --gen_all_targets HOT 1
- Can't generate correct ninja rules for certain Makefile HOT 1
- Escaped percent char is mishandled in patsubst arguments HOT 1
- Assignment statement should not allow a whitespace in variable's name HOT 1
- Ninja file generated by Kati depends on irrelevant variables
- $* gives incorrect value when the stem is in the middle of the pattern
- Implicit rules cannot invoke other implicit rules HOT 2
- Windows port HOT 4
- kati doesn't support .SECONDEXPANSION
- Ignoring errors
- Kati fails to translate # in ninja mode HOT 1
- TestKati/stem_middle.mk: Kati generates "a" and "c" directories. HOT 1
- Target considered up-to-date when prerequisite is newer
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kati.