Giter Club home page Giter Club logo

Comments (8)

shinh avatar shinh commented on July 23, 2024

Thanks for the patch! I think you are not a Google employee. We need ask you to sign "Contributor License Agreements" to accept patches. Could you review and sign it?

https://cla.developers.google.com/clas

Also, your patch doesn't contain your name nor your email address. Could you tell me them so I can set appropriate info (or it's easier for me if you can make PRs)?

from kati.

stefanb2 avatar stefanb2 commented on July 23, 2024

I'm working for a company that is a Google partner. This work has been done on company time and company resources. But this is my private GitHub account, that's why I removed my company email address from the patch. If there is some other channel than GitHub for Google partners to submit fixes/improvements then please point me in the right direction.

If Github is the only channel and forking the project is the preferred method for submitting changes, then I'll have to cherry-pick the changes to the new branch with my private email address.

from kati.

shinh avatar shinh commented on July 23, 2024

I'm not familiar with our licensing policies around partners. If you want, I can ask the question internally. But yeah, if you can send a PR from your private address and sign the CLA, it's easier for me.

from kati.

stefanb2 avatar stefanb2 commented on July 23, 2024

I'll need to check if I'm allowed to sign the "on behalf of your employer" variant of the CLA. If not then I'll agree with my boss to submit these changes as private contributions.

from kati.

shinh avatar shinh commented on July 23, 2024

Any update? I chatted with people who are usually working with partner companies. Their answer sounded like asking you or your company to sign the CLA is the only option.

from kati.

stefanb2 avatar stefanb2 commented on July 23, 2024

I've initiated the necessary company internal process to get approval for upstream contributions. Stay tuned....

from kati.

shinh avatar shinh commented on July 23, 2024

Great, thanks!

from kati.

stefanb2 avatar stefanb2 commented on July 23, 2024

The internal process finally completed and I pushed my changes to my fork. Please have a look at the cumulative PR #58.

from kati.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.