Giter Club home page Giter Club logo

Comments (3)

shinh avatar shinh commented on July 23, 2024

Though you have workarounded the issue by not using --use_find_emulator, two issues were found thanks to your report:

  1. Kati thought symlink/file did not exist when symlink points a path outside the directories FindEmulator knew
  2. Kati's findleaves.py didn't follow symlinks and it didn't fall back to the command execution.

1 was fixed by bd3bb23
2 was fixed by b717561

As for 2, for your case (all top-level directories are symlinks) FindEmulator still just falls back to normal $(shell) command execution. This means you still don't have the performance improvement by FindEmulator (~20 secs for me), but you should be able to build your branch with --use_find_emulator after updating build/kati.

from kati.

shinh avatar shinh commented on July 23, 2024

and

407d8d4

should make FindEmulator work nicely with your setup.

from kati.

redpig avatar redpig commented on July 23, 2024

It's been performing well in a variety of test cases - thanks!

from kati.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.