Comments (7)
Whoops looks like this one fell through the cracks. Thanks for deduping this with the other issue @thecodingwizard. #9979 should fix this.
from gvisor.
I think the failure to exit has something to do with an ignored SIGCHILD. I can see this in the debug logs:
D0901 23:13:30.747875 529435 task_signals.go:443] [ 1: 1] Discarding ignored signal 17
and if I modify the Python program to handle SIGCHILD I can get the shell to exit using the exit
program.
import os
import pty
import signal
def handler(signum, frame):
print('Signal handler called with signal', signum)
os.waitpid(-1, 0)
raise KeyboardInterrupt()
# gVisor is ignoring the SIGCHILD 'Discarding ignored signal 17'
signal.signal(signal.SIGCHLD, handler)
try:
pty.spawn("sh")
except KeyboardInterrupt:
print("child exited")
$ docker run -it --runtime=runsc python:3.9.9-slim-bullseye python3 -c "$(cat minimal_exit.py)"
# exit
Signal handler called with signal 17
child exited
$
from gvisor.
The issue with CTRL-D handling appears to be that inputQueueRead
in line_discipline.go
cannot send EOF (return 0, nil
) to the replicaFD when a CTRL-D is sent and the buffer is empty.
from gvisor.
Thanks for digging into the issue! Do you have a ready patch for a fix? I am happy to review and merge the PR
from gvisor.
I've opened #9336 which attempts to address the CTRL-D issue, but haven't yet looked at the signal issue.
from gvisor.
A friendly reminder that this issue had no activity for 120 days.
from gvisor.
I can reproduce this with
import pty
pty.spawn(["python3", "-c", "print('hello')"])
As well as
import os
from pty import _copy
pid, fd = os.forkpty()
if pid == 0:
try:
os.setsid()
except OSError:
# os.forkpty() already set us session leader
pass
os.execlp("python3", "python3", "-c", "print('hi')")
_copy(fd)
print("I will never run on gvisor")
os.close(fd)
print(os.waitpid(pid, 0)[1])
I think the root cause may be that _copy
calls select()
system call, and that system call never returns when the child process exits. I made a new issue for that here: #9951
from gvisor.
Related Issues (20)
- runsc --platform=systrap fails with "panic: seccomp failed: invalid argument" HOT 3
- Problem in building gvisor on ARM64 HOT 4
- [Feature] Asking for support for termux on android(with termux-glibc) HOT 3
- NV2080_CTRL_CMD_GRMGR_GET_GR_FS_INFO: Missing nvproxy ioctl used by NCCL HOT 2
- feed does not validate HOT 1
- Restoring a checkpointed container with a different OCI spec HOT 8
- Mark C ABI structs with `structs.HostLayout`
- segfault: buffer.View possibly released twice resulting in nil chunk HOT 8
- /proc/sys/net/core/rmem_default is visible in non-root network namespaces in recent Linux kernels HOT 1
- //test/syscalls/linux:prctl_test fails to build on x86_64 host because of aarch64 dependencies HOT 2
- runsc: Duplicate container creation deletes the existing container and causes resources leak
- File descriptors not being closed on write to mountpoint-s3 HOT 16
- runsc (in docker): fork/exec /proc/self/exe: read-only file system HOT 5
- gVisor CNI tutorial is not working as expected
- Support no-op `personality(2)` bits
- Regression in recent version? error: setsockopt(..., IP_MTU_DISCOVER, IP_PMTUDISC_OMIT...) failed: Not supported HOT 5
- No obvious way to checkpoint a container when TCP sockets have been recently closed and are in TIME_WAIT state in the kernel HOT 2
- sysctl options declared in config.json not applied to container HOT 3
- Poor performance when switching to multiple CPU Cores HOT 7
- Runtime fails to mount /sys when --tpuproxy is provided HOT 20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gvisor.