Giter Club home page Giter Club logo

Comments (4)

khavishbhundoo avatar khavishbhundoo commented on May 18, 2024

ignore or delete that commit....sorry i am new to github

from guetzli.

khavishbhundoo avatar khavishbhundoo commented on May 18, 2024

I just started learning c++ so forgive my ignorance

Check my attempt to solve the problem
khavishbhundoo@f4c3a33

However i seems to get an issue in trying to get bazel to see my changes while compiling(sounds crazy and stupid)

I tried the following

Modified the error message (Guetzli processing failed) to something else and then ran bazel clean and bazel build -c opt //:guetzli.Surprising the error shown is still Guetzli processing failed

from guetzli.

Furniel avatar Furniel commented on May 18, 2024

I think we should allow optimization only with one image as argument, code will look like this:
https://github.com/Furniel/guetzli/commit/5252181fa2e1d79527b4618d7569b6e07477f0e1
With this patch image optimization works with input image or with input and optput images(output can be same).
That`s not final code, if we want allow use guetzli only with one arg we should check input image format. Everything works good if input image is jpg but if input is png - output will be written to png too now(that's not good idea).

from guetzli.

robryk avatar robryk commented on May 18, 2024

@Furniel I don't want to encourage people to use the same file for input and output, because it generally creates confusion that leads to someone running an image through Guetzli twice (or more). Passing an image multiple times through Guetzli is not equivalent to passing it once, and will generate visible artifacts.

from guetzli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.