Comments (4)
ignore or delete that commit....sorry i am new to github
from guetzli.
I just started learning c++ so forgive my ignorance
Check my attempt to solve the problem
khavishbhundoo@f4c3a33
However i seems to get an issue in trying to get bazel to see my changes while compiling(sounds crazy and stupid)
I tried the following
Modified the error message (Guetzli processing failed
) to something else and then ran bazel clean
and bazel build -c opt //:guetzli
.Surprising the error shown is still Guetzli processing failed
from guetzli.
I think we should allow optimization only with one image as argument, code will look like this:
https://github.com/Furniel/guetzli/commit/5252181fa2e1d79527b4618d7569b6e07477f0e1
With this patch image optimization works with input image or with input and optput images(output can be same).
That`s not final code, if we want allow use guetzli only with one arg we should check input image format. Everything works good if input image is jpg but if input is png - output will be written to png too now(that's not good idea).
from guetzli.
@Furniel I don't want to encourage people to use the same file for input and output, because it generally creates confusion that leads to someone running an image through Guetzli twice (or more). Passing an image multiple times through Guetzli is not equivalent to passing it once, and will generate visible artifacts.
from guetzli.
Related Issues (20)
- Bazel build failing with permission denied HOT 4
- New Butteraugli from Pik HOT 1
- Strange behavior at higher DPI or Resolution HOT 7
- What is the sign that the program completes HOT 3
- error while loading shared libraries: libpng16.so.16: cannot open shared object file: No such file or directory HOT 1
- Excessive blocking artifacts on soft gradients
- Linker Tools Errors please help HOT 2
- Is this code neccessary if the input jpeg is already grayscale? HOT 4
- Parallel build breaks
- installation error
- node_modules\guetzli\vendor already exists HOT 2
- sRGB vs gamma HOT 2
- Better return codes HOT 1
- Empty progress function
- Update Visual Studio project to VS 2019 HOT 1
- RPM for CentOS7
- Golden files test is broken due to missing archive
- Can't open input file HOT 2
- How do you prevent Guetzli from running twice on the same file HOT 1
- Cannot Compress Binary Images HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from guetzli.