Giter Club home page Giter Club logo

Comments (5)

max-vogler avatar max-vogler commented on August 16, 2024

Thanks for the detailed bug report - pointing out the source line, TODO comment and required fix really helps us to fix this.

The TODO comment mentions AppVeyor as reason preventing the upgrade, which is a service we no longer use. If you have some time and want to contribute to GRR, please send a pull requests that upgrades the cryptography library to "cryptography==3.3.2" specifically.

The library is pinned in the file you linked grr/api_client/python/setup.py as core/setup.py. Please update both and feel free to remove the AppVeyor TODO comment.

If you don't have the time or the update breaks tests or has other complications, I'll look into it next week.

from grr.

digitalisx avatar digitalisx commented on August 16, 2024

Hello, @max-vogler 🙂
Thank you for reviewing my issue!

As you said, I will submit the PR related to the version upgrade within this week.

I'd appreciate it if you could pay attention until the problem is solved.
And Feel free to leave a thread if there are other ways to solve this issue!

from grr.

digitalisx avatar digitalisx commented on August 16, 2024

A release for PyPi is required for normal application and use of the patch in other DFIR projects.
When I looked at the Release and Github Actions, Merge does not mean Release, so We need to review it.

from grr.

mbushkov avatar mbushkov commented on August 16, 2024

@digitalisx - we'll update the PyPi grr-api-client packages as part of the current GRR release. Can't give you a precise ETA, but should happen within 2 weeks or so.

from grr.

digitalisx avatar digitalisx commented on August 16, 2024

Thank you for your comments @mbushkov,
I think the release time is purely up to Maintainers' authority and decision!
I was just recording the things that I needed to check to solve this problem correctly.
Please do it whenever you have time :)

from grr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.