all: remove stutter from package names about go-cloud HOT 8 CLOSED

@tbpg awscloud and gcpcloud are unlikely to be imported together, but some of the other ones (s3, sql, xray) would collide with the provider-given packages.

While there's some stutter in the import path, I liken this to "path/filepath": the name file would not be evocative enough of the package's purpose.

from go-cloud.

The naming collisions and readability arguments win out here, let's keep the status quo.

from go-cloud.

Those names are nicer for sure from a maintainer's point of view, but less descriptive from a user's point of view. A maintainer sees blob/fileblob vs blob/file but a user sees fileblob.Whatever vs file.Whatever. The latter is nicer for the maintainer but the former is nicer for the user.

from go-cloud.

I'm personally in favor of the renames as suggested. Assigning to @zombiezen and @shantuo for other votes.

from go-cloud.

But I understand @jadekler 's reservations. I think in the end, the idiomatic aspects outweigh the readability aspects, if the dev is having issues they can always alias the package.

from go-cloud.

aws/awscloud      -> aws/cloud
gcp/gcpcloud      -> gcp/cloud

These are the only two I might be concerned about. Would it be common for users to import both of these into a single package?

I'm thinking of this paragraph from https://blog.golang.org/package-names:

Avoid unnecessary package name collisions. While packages in different directories may have the same name, packages that are frequently used together should have distinct names. This reduces confusion and the need for local renaming in client code. For the same reason, avoid using the same name as popular standard packages like io or http.

from go-cloud.

What does usage look like? The calling code should help inform the package name. If it's an underscore import, then I agree w/ the proposal. If not, cloud seems like an overly generic name for the import.

from go-cloud.

The calling code will not be using underscore imports; they will be referring to the provider sets inside the package (current examples are awscloud.Services and awscloud.AWS).

from go-cloud.