Hi, I just tried building the latest HEAD with MSVC 2019 and it builds fine.

To be precise, I used VS 2022 but setting it up to use MSVC 2019.
For some reason, my VS 2019 installation doesn't seem to work anymore (I get a BSOD). It's probably an issue with my installation and unrelated to Fruit.

I used this CMakeSettings.json:

{
  "configurations": [
    {
      "name": "x64-Release MSVC 2019",
      "generator": "Visual Studio 16 2019 Win64",
      "configurationType": "Release",
      "buildRoot": "${projectDir}\\out\\build\\${name}",
      "cmakeCommandArgs": "-DFRUIT_USES_BOOST=False",
      "buildCommandArgs": "",
      "intelliSenseMode": "windows-msvc-x64"
    }
  ]
}

Were you building from HEAD or from the last release?
If you used the last release, I recommend you try HEAD.

Can you provide some more details on how you built it, e.g. posting the CMakeSettings.json and any other configuration / commands that you used?
Then I can try to reproduce the issue using those instructions.

Thanks

from fruit.

In CMakeLists.txt

Before the project(FRUIT... line I added:

Visual Studio 2022

cmake_minimum_required(VERSION 3.21)

Visual Studio 2019

#cmake_minimum_required(VERSION 3.20)

The line after I added set(CMAKE_VERBOSE_MAKEFILE ON)

I seem to have a CMakePresetts.json rather than a CMakeSettings.json.

The setting for MSVC is:

      "displayName": "Windows x64 Debug",
      "description": "Target Windows with the Visual Studio development environment.",
      "generator": "Ninja",
      "binaryDir": "${sourceDir}/out/build/${presetName}",
      "architecture": {
        "value": "x64",
        "strategy": "external"
      },
      "cacheVariables": {
        "CMAKE_BUILD_TYPE": "Debug",
        "CMAKE_INSTALL_PREFIX": "${sourceDir}/out/install/${presetName}"`
      },
      "vendor": { "microsoft.com/VisualStudioSettings/CMake/1.0": { "hostOS": [ "Windows" ] } }

I have been building fruit with Boost, and I cloned the repository via the Visual Studio Start Window on the 8th.

from fruit.

@poletti-marco Is there any more information you would like me to supply?

from fruit.

@poletti-marco hit the wrong button, still trying to get to the bottom of this

from fruit.

Hi @poletti-marco,

I've just spotted the releases page https://github.com/google/fruit/releases/tag/v3.6.0

Once I extracted the attached Zip File, and modified the CMakeLists.txt to target my current Visual Studio's. I was able to install the fruit library successfully.

I haven't yet attempted to build any of the samples with it because I haven't had enough time in the work day to get it done, however I did also manage to build the samples against the vcpkg, using "Project from existing code", to create the projects, and the vcpkg project integration, and through that I was able to combine and run the samples

from fruit.

from fruit.

@poletti-marco

I think we can probably close this issue, as it doesn't exist in the last released version of fruit-3.6.0, it only occurs when cloning the current state of the repository.

Or would you like it to stay open to log the fact there is a problem specific to MSVC in the repository as it stands?

from fruit.

from fruit.