Giter Club home page Giter Club logo

Comments (3)

gitcliff avatar gitcliff commented on June 7, 2024

@kimaina just an inquiry on this one....
The entire batch processing literally uses the beam API, so in this case to fetch the max ID for each table would require us to shift the logic to new util class establish the db connection, fetch the max id and then do a reference to the method in this util class in the FhirEtl class ...WDYT about this approach?
@bashir2

from fhir-data-pipes.

kimaina avatar kimaina commented on June 7, 2024

I agree we should move these methods into common, including the function to fetch json

from fhir-data-pipes.

bashir2 avatar bashir2 commented on June 7, 2024

This was already done as part of the original PR #72; the specific commit making this change is this one which is similar to what you are saying @gitcliff.

from fhir-data-pipes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.