[Feature request] Automatically disable checks based on target Java version about error-prone HOT 3 OPEN

Hi @Marcono1234! For StatementSwitchToExpressionSwitch such skip-if-unsupported logic is already in place; did you observe that not working as expected?

Assuming that logic does work for you: the other checks could likely be tweaked accordingly.

from error-prone.

Ah sorry you are right, for StatementSwitchToExpressionSwitch it seems to work as desired. I only had a look at some of the listed checks and noticed that they don't consider the target Java version, but then listed additional Java version dependent checks without verifying how they behave.

Assuming that logic does work for you: the other checks could likely be tweaked accordingly.

Yes that sounds like a good idea! I have extended the list above with some more checks which might be Java target version dependent.

However, would it make sense to implement a more general solution which allows checks to specify an optional minimum Java version? And then maybe directly disable the checks on startup instead of executing them all the time despite them doing nothing (but still causing some overhead I guess); or can the target / source Java version differ between the files to be compiled?

from error-prone.

However, would it make sense to implement a more general solution which allows checks to specify an optional minimum Java version? And then maybe directly disable the checks on startup instead of executing them all the time despite them doing nothing (but still causing some overhead I guess); or can the target / source Java version differ between the files to be compiled?

I think that could make sense, and the source version should always be the same for the entire compilation. I'm a little skeptical that the overhead of the approach StatementSwitchToExpressionSwitch uses is going to be noticeable in practice, so adding a separate API for checks to express a required source version doesn't feel like a high priority to me. But I'm open to being persuaded if you're seeing overhead from that in practice.

from error-prone.