Giter Club home page Giter Club logo

Comments (6)

pisuke avatar pisuke commented on May 28, 2024

Also "saturation" should be a measurement and not a measurement description.

from digitalbuildings.

charbull avatar charbull commented on May 28, 2024

@pisuke can you send a pull request please?

from digitalbuildings.

tasodorff avatar tasodorff commented on May 28, 2024

@pisuke for saturation and brightness, what would the units be?

We can open a PR and fix this, but we will also need to see if this breaks anything that has already been defined in Carson.

from digitalbuildings.

charbull avatar charbull commented on May 28, 2024

@pisuke @tasodorff any updates on this?
@mschulze17 fyi

from digitalbuildings.

abe-101 avatar abe-101 commented on May 28, 2024

@pisuke can you send a pull request please?

I'd be happy to contribute and open a pull request.

Is it just moving line:

brightness: "Giving out or reflecting light; overall level of light in a space."

and line:
saturation: "Point at which no more of a material can be absorbed into another material."

to the measurement section?

from digitalbuildings.

charbull avatar charbull commented on May 28, 2024

@cstirdivant @tasodorff ptal

from digitalbuildings.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.